Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

2014-12-21 Thread Stefan Hajnoczi
On Sun, Dec 21, 2014 at 10:43 PM, Rickard Strandqvist wrote: > The NULL check was done to late, and there it was a risk > of a possible null pointer dereference. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > --- >

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

2014-05-20 Thread Dan Carpenter
On Mon, May 19, 2014 at 11:39:00PM +0200, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist This one is called from line6_disconnect

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

2014-05-20 Thread Stefan Hajnoczi
On Mon, May 19, 2014 at 11:39 PM, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/line6/toneport.c | 14 +