Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-24 Thread Greg Kroah-Hartman
On Fri, Mar 20, 2015 at 04:19:36PM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman > wrote: > > On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote: > >> Gcc < 4.3 doesn't understand binary constants (0b*): > >> > >> drivers/stagi

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-20 Thread Geert Uytterhoeven
Hi Greg, On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman wrote: > On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote: >> Gcc < 4.3 doesn't understand binary constants (0b*): >> >> drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix "b111" on >> integer constant

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-20 Thread Greg Kroah-Hartman
On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote: > Gcc < 4.3 doesn't understand binary constants (0b*): > > drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix "b111" on > integer constant > drivers/staging/fbtft/fb_hx8340bn.c:159:3: error: invalid suffix "b"

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-10 Thread Joe Perches
On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote: > Gcc < 4.3 doesn't understand binary constants (0b*): trivia: > diff --git a/drivers/staging/fbtft/fb_hx8340bn.c > b/drivers/staging/fbtft/fb_hx8340bn.c [] > @@ -156,10 +156,10 @@ static int set_var(struct fbtft_par *par) > static in

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-10 Thread Geert Uytterhoeven
Hi Joe, On Tue, Mar 10, 2015 at 10:50 PM, Joe Perches wrote: > On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote: >> Gcc < 4.3 doesn't understand binary constants (0b*): > > trivia: > >> diff --git a/drivers/staging/fbtft/fb_hx8340bn.c >> b/drivers/staging/fbtft/fb_hx8340bn.c > [] >> @