Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-19 Thread Gao Xiang
On 2019/3/20 11:22, Gao Xiang wrote: > Hi Julian, > > On 2019/3/20 1:19, Julian Merida wrote: >> Yes that was my mistake, I'm really sorry!! This was my first contribution >> to the kernel and I didn't know who to send the email despite the >> maintainers. Also, I thought I shouldn't bother mo

Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-19 Thread Gao Xiang
Hi Julian, On 2019/3/20 1:19, Julian Merida wrote: > Yes that was my mistake, I'm really sorry!! This was my first contribution to > the kernel and I didn't know who to send the email despite the maintainers. > Also, I thought I shouldn't bother more than necessary. > > Gao then told me I shoul

Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-19 Thread Gao Xiang
Hi Greg, On 2019/3/19 21:28, Greg KH wrote: > On Mon, Mar 18, 2019 at 08:58:41PM -0300, Julian Merida wrote: >> Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" >> >> Signed-off-by: Julian Merida >> Reviewed-by: Gao Xiang > > Was this really reviewed by Gao? Offline

Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-19 Thread Greg KH
On Mon, Mar 18, 2019 at 08:58:41PM -0300, Julian Merida wrote: > Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" > > Signed-off-by: Julian Merida > Reviewed-by: Gao Xiang Was this really reviewed by Gao? Offline or on-list? I missed it if it was on-list :( thanks,

Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-18 Thread Gao Xiang
On 2019/3/18 12:14, Julian Merida wrote: > Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" > > Signed-off-by: Julian Merida looks good to me personally, you can add: Reviewed-by: Gao Xiang btw, I cc greg and staging mailing list, could you please resend this pat