Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-14 Thread Ian Abbott
On 12/06/15 21:20, julien.de...@gmail.com wrote: From: Julien Dehee comedi/comedi_fops.c use ENODEV following open manual comedi/drivers.c use ENOTTY following ioctl manual drivers/serial2002.c use ENOTTY following ioctl manual Signed-off-by: Julien Dehee --- drivers/stagin

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 03:26:26PM -0700, Greg KH wrote: > On Fri, Jun 12, 2015 at 10:06:16PM +0100, One Thousand Gnomes wrote: > > On Fri, 12 Jun 2015 13:43:27 -0700 > > Greg KH wrote: > > > > > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > > > > From: Julien Dehee >

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 10:06:16PM +0100, One Thousand Gnomes wrote: > On Fri, 12 Jun 2015 13:43:27 -0700 > Greg KH wrote: > > > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > > > From: Julien Dehee > > > > > > comedi/comedi_fops.c > > > use ENODEV following open

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread One Thousand Gnomes
On Fri, 12 Jun 2015 13:43:27 -0700 Greg KH wrote: > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > > From: Julien Dehee > > > > comedi/comedi_fops.c > > use ENODEV following open manual That should probably be ENXIO by a strict reading, but Linux has always used

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > From: Julien Dehee > > comedi/comedi_fops.c > use ENODEV following open manual > > comedi/drivers.c > use ENOTTY following ioctl manual > > drivers/serial2002.c > use ENOTTY following ioctl manual What do you