Re: [PATCH] staging/gasket: Fix string split

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 05:46:39PM +0200, Tianzheng Li wrote: > This patch removes unnecessary quoted string splits. > > Reported-by: Jie Zhang > Signed-off-by: Tianzheng Li > --- > drivers/staging/gasket/gasket_core.c | 6 ++ > drivers/staging/gasket/gasket_ioctl.c | 3 +-- >

Re: [PATCH] staging/gasket: Fix string split

2019-05-23 Thread Dan Carpenter
On Thu, May 23, 2019 at 05:11:56PM +0200, 李天正 wrote: > Hello, > we are doing a project in the university and we cooperated to make this > patch. Some warnings are found by Mr.Zhang. Use the Reported-by to show who found the bug or Co-developed-by: if you both wrote code. regards, dan carpenter _

Re: [PATCH] staging/gasket: Fix string split

2019-05-21 Thread Dan Carpenter
On Tue, May 21, 2019 at 05:07:28PM +0200, Tianzheng Li wrote: > This patch removes unnecessary quoted string splits. > > Signed-off-by: Tianzheng Li > Signed-off-by: Jie Zhang What do the two sign off mean here? What did Jie Zhang do? Who wrote this patch? Co-developed-by? Reviewed-by? reg

Re: [PATCH] staging/gasket: Fix string split

2019-05-21 Thread Greg KH
On Tue, May 21, 2019 at 03:50:12PM +0200, Tianzheng Li wrote: > This patch removes unnecessary quoted string splits. > Signed-off-by: Tianzheng Li > Signed-off-by: Jie Zhang We need a blank line before the signed-off-by line. Care to fix this up and resend? thanks, greg k-h __