Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Dan Carpenter
On Fri, Dec 07, 2018 at 09:31:06AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 7 Dec 2018 12:14:50 +0100 > Hans Verkuil escreveu: > > > On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > > > A common mistake is to assume that initializing a var with: > > > struct foo f = { 0 }; > > > > >

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:27:09 + Ian Arkver escreveu: > On 07/12/2018 11:37, Hans Verkuil wrote: > > On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: > >> Em Fri, 7 Dec 2018 12:14:50 +0100 > >> Hans Verkuil escreveu: > >> > >>> On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > >>

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Ian Arkver
On 07/12/2018 11:37, Hans Verkuil wrote: On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: Em Fri, 7 Dec 2018 12:14:50 +0100 Hans Verkuil escreveu: On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: A common mistake is to assume that initializing a var with: struct foo f = { 0 }

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Hans Verkuil
On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: > Em Fri, 7 Dec 2018 12:14:50 +0100 > Hans Verkuil escreveu: > >> On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: >>> A common mistake is to assume that initializing a var with: >>> struct foo f = { 0 }; >>> >>> Would initialize a zero

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Mauro Carvalho Chehab
Em Fri, 7 Dec 2018 12:14:50 +0100 Hans Verkuil escreveu: > On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > > A common mistake is to assume that initializing a var with: > > struct foo f = { 0 }; > > > > Would initialize a zeroed struct. Actually, what this does is > > to initialize th

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Hans Verkuil
On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > A common mistake is to assume that initializing a var with: > struct foo f = { 0 }; > > Would initialize a zeroed struct. Actually, what this does is > to initialize the first element of the struct to zero. > > According to C99 Standard