Re: [PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

2016-09-23 Thread Colin Ian King
On 23/09/16 19:20, Vaibhav Agarwal wrote: > On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman > wrote: >> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently, if info is null, the dev_err message is dereferencing an >>> uninitialized module po

Re: [PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

2016-09-23 Thread Vaibhav Agarwal
On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman wrote: > On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently, if info is null, the dev_err message is dereferencing an >> uninitialized module pointer. Instead, initialize module before the >> de

Re: [PATCH] greybus: audio: ensure module is set to avoid crash on dev_err message

2016-09-23 Thread Greg Kroah-Hartman
On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote: > From: Colin Ian King > > Currently, if info is null, the dev_err message is dereferencing an > uninitialized module pointer. Instead, initialize module before the > dev_err call to fix this issue. > > Found using static analysis with