Re: [PATCH] Fix coding style issues

2020-07-24 Thread Greg Kroah-Hartman
On Sat, Jul 25, 2020 at 01:55:19AM +0530, Anant Thazhemadam wrote: > Coding style issues found were rectified > > Signed-off-by: Anant Thazhemadam > --- > drivers/staging/rtl8188eu/core/rtw_security.c | 92 ++- > 1 file changed, 47 insertions(+), 45 deletions(-) > > diff --git a

Re: [PATCH] fix coding style issue use octal permission instead of decimal

2017-02-10 Thread Greg KH
On Fri, Feb 10, 2017 at 05:47:11PM +0900, Chetan Sethi wrote: > This is a patch to the dim2_hdm.c file that fixes coding style error found > by checkpatch.pl > > Signed-off-by: Chetan Sethi > --- > drivers/staging/most/hdm-dim2/dim2_hdm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH] fix coding style

2016-10-24 Thread Dan Carpenter
Fix the subject. Add a changelog. Add a signed-off-by. Break the patch into three patches where each patch cleans up a specific type of coding style warning. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.

Re: [PATCH] fix coding style

2016-10-23 Thread Alexander Alemayhu
On Sun, Oct 23, 2016 at 05:31:09PM +0800, Jiong Du wrote: > --- > drivers/staging/ks7010/michael_mic.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > Looks like you are missing a topic. You could add 'staging: ks7010:'. Which seems to be used by others when looking

Re: [PATCH] Fix coding style issues.

2015-08-05 Thread Greg KH
On Wed, Aug 05, 2015 at 11:19:53PM +0300, Lior Pugatch wrote: > This patch fixes checkpatch.pl warnings, > related to comments. > > Signed-off-by: Lior Pugatch > --- > drivers/staging/panel/panel.c | 38 +- > 1 file changed, 25 insertions(+), 13 deletions(-) >

Re: PATCH: Fix coding style warning.

2014-11-08 Thread Dan Carpenter
On Sat, Nov 08, 2014 at 06:39:06PM +0200, sharon wrote: > Fix coding style warning. > (First submission, sorry in advance for any dumb stuff I'm missing. > Let me know and I'll fix it.) > Everyone's first patch is rejected. 1) You need to work against linux-next. 2) Fix the subject: [PATCH] bi

Re: PATCH: Fix coding style warning.

2014-11-08 Thread Greg KH
On Sat, Nov 08, 2014 at 06:39:06PM +0200, sharon wrote: > Fix coding style warning. What coding style warning? Be specific please. And your subject:, you aren't saying where in the kernel you are fixing anything, look at other patches for this file in git, what did the subject look like for them

Re: [PATCH] fix coding style issue

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 11:25:58AM -0400, rbasukala wrote: > Signed-off-by: rbasukala > --- > drivers/staging/netlogic/xlr_net.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/netlogic/xlr_net.c > b/drivers/staging/netlogic/xlr_net.c > index e320d6

Re: [PATCH] fix coding style issues

2014-06-03 Thread Dan Carpenter
On Tue, Jun 03, 2014 at 09:21:18PM +0200, Nicolas Koch wrote: > Done as task 10 of the eudyptula challenge. > There is no subject prefix. The subject should be: [patch] Staging: octeon: minor style cleanups Otherwise the patch is ok. regards, dan carpenter ___

Re: [PATCH] Fix coding style in drivers/staging/crystalhd/crystalhd_lnx.c

2014-04-13 Thread Greg Kroah-Hartman
On Sun, Apr 13, 2014 at 05:35:46PM +0200, Pascal COMBES wrote: > From: Pascal COMBES > > Fix alignement issues and two or three other coding style problems in > drivers/staging/crystalhd/crystalhd_lnx.c. Patches need to do one thing, as you are addressing a number of different things all in one

Re: [PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Dan Carpenter
The subject should be: [PATCH] Staging: netlogic: long lines in xlr_net.c You were missing the subsystem prefix: "Staging: netlogic:". regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/

Re: [PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Dan Carpenter
On Fri, Mar 28, 2014 at 10:43:43AM +0100, Neil Armstrong wrote: > checkpatch script returns the following warning: > WARNING: line over 80 characters > 310: FILE: drivers/staging/netlogic/xlr_net.c:310: > + void *accel_priv, select_queue_fallback_t fallback) > > This patch fixes the