On Sun, Nov 01, 2015 at 10:10:59AM -0800, Greg Kroah-Hartman wrote:
> On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote:
> > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote:
> > > BIT macro is used for defining bit location instead of shifting
> > > operator - coding style issue
> >
On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote:
> > BIT macro is used for defining bit location instead of shifting
> > operator - coding style issue
>
> > #define APCI1032_CTRL_INT_OR (0 << 1)
>
> > +#define APCI1032
On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote:
> BIT macro is used for defining bit location instead of shifting
> operator - coding style issue
> #define APCI1032_CTRL_INT_OR (0 << 1)
> +#define APCI1032_CTRL_INT_AND BIT(1)
And now you have two styles at the same time. I
