Re: [PATCH] checkpatch: Warn on macros with flow control statements

2014-09-10 Thread Drokin, Oleg
Hello! On Sep 10, 2014, at 10:36 AM, Joe Perches wrote: > On Wed, 2014-09-10 at 16:06 +0200, Julia Lawall wrote: >> On Wed, 10 Sep 2014, Joe Perches wrote: >>> On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote: On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote: > Macros wi

Re: [PATCH] checkpatch: Warn on macros with flow control statements

2014-09-10 Thread Joe Perches
On Wed, 2014-09-10 at 16:06 +0200, Julia Lawall wrote: > On Wed, 10 Sep 2014, Joe Perches wrote: > > On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote: > > > On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote: > > > > Macros with flow control statements (goto and return) are > > > > n

Re: [PATCH] checkpatch: Warn on macros with flow control statements

2014-09-10 Thread Julia Lawall
On Wed, 10 Sep 2014, Joe Perches wrote: > On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote: > > On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote: > > > Macros with flow control statements (goto and return) are > > > not very nice to read as any flow movement is unexpected. > > bre

Re: [PATCH] checkpatch: Warn on macros with flow control statements

2014-09-10 Thread Joe Perches
On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote: > On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote: > > Macros with flow control statements (goto and return) are > > not very nice to read as any flow movement is unexpected. break and continue are also flow control statements but

Re: [PATCH] checkpatch: Warn on macros with flow control statements

2014-09-10 Thread Dan Carpenter
On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote: > Macros with flow control statements (goto and return) are > not very nice to read as any flow movement is unexpected. > > Try to highlight them and emit a warning on their definition. > > Avoid warning on macros that use argument conc