Re: [PATCH] checkpatch: Improve missing blank line after declarations test

2014-05-05 Thread Andrew Morton
On Mon, 05 May 2014 15:35:43 -0700 Joe Perches wrote: > > @@ -67,6 +68,7 @@ long vfs_truncate(struct path *path, lof > > { > > struct inode *inode; > > long error; > > + wobble(); > > > > inode = path->dentry->d_inode; > > Patch content can be a bit odd when lines are > both add

Re: [PATCH] checkpatch: Improve missing blank line after declarations test

2014-05-05 Thread Joe Perches
On Mon, 2014-05-05 at 15:15 -0700, Andrew Morton wrote: > On Mon, 05 May 2014 13:12:16 -0700 Joe Perches wrote: > > > A couple more modifications to the declarations tests. > > > > o Declarations can also be bitfields so exclude things with a colon > > o Make sure the current and previous lines

Re: [PATCH] checkpatch: Improve missing blank line after declarations test

2014-05-05 Thread Andrew Morton
On Mon, 05 May 2014 13:12:16 -0700 Joe Perches wrote: > A couple more modifications to the declarations tests. > > o Declarations can also be bitfields so exclude things with a colon > o Make sure the current and previous lines are indented the same > to avoid matching some macro where a struc