Re: [PATCH] Staging:tidspbridge: Fixing coding style

2014-03-01 Thread Dan Carpenter
This patch introduces bugs. On Fri, Feb 28, 2014 at 06:15:52PM -0800, Masood Mehmood wrote: > > > Fixing some basic coding style issues. > Changelog sucks. Doesn't say what the changes are. > Signed-off-by: Masood Mehmood > --- > drivers/staging/tidspbridge/rmgr/node.c | 23 +++---

Re: [PATCH] Staging:tidspbridge: Fixing coding style

2014-02-28 Thread Greg Kroah-Hartman
On Fri, Feb 28, 2014 at 12:30:04AM -0800, Masood Mehmood wrote: > > On Fri, Feb 28, 2014 at 07:01:56PM -0800, Greg Kroah-Hartman wrote: > > On Fri, Feb 28, 2014 at 06:15:52PM -0800, Masood Mehmood wrote: > > > > > > > > > > > Fixing some basic coding style issues. > > > > Which issues did you

Re: [PATCH] Staging:tidspbridge: Fixing coding style

2014-02-28 Thread Masood Mehmood
On Fri, Feb 28, 2014 at 07:01:56PM -0800, Greg Kroah-Hartman wrote: > On Fri, Feb 28, 2014 at 06:15:52PM -0800, Masood Mehmood wrote: > > > > > > > Fixing some basic coding style issues. > > Which issues did you fix? Please be more specific. Did you fix them > for the whole driver, or just a

Re: [PATCH] Staging:tidspbridge: Fixing coding style

2014-02-28 Thread Greg Kroah-Hartman
On Fri, Feb 28, 2014 at 06:15:52PM -0800, Masood Mehmood wrote: > > > Fixing some basic coding style issues. Which issues did you fix? Please be more specific. Did you fix them for the whole driver, or just a specific file? And what's with the odd multiple attachments? thanks, greg k-h ___