Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-30 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote: > On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote: > > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: > > > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) > > > wrote: > > > > setup_time

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-18 Thread Joe Perches
On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > > setup_timer is used for timer parameter setup rather than direct > > assignment > > > > Signed-off-by: Gnanachandran Dhanapal > > your From: name and Sign

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-18 Thread Julia Lawall
> void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data) > { > - ptimer->function = fun; > - ptimer->data = data; > init_timer(ptimer); > + setup_timer(ptimer, fun, data); > } setup_timer also subsumes init_timer. Check the definition. Probably you can

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-18 Thread Sudip Mukherjee
On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote: > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: > > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) > > wrote: > > > setup_timer is used for timer parameter setup rather than direct > > > assignment > >

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-18 Thread Sudip Mukherjee
On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > setup_timer is used for timer parameter setup rather than direct > assignment > > Signed-off-by: Gnanachandran Dhanapal your From: name and Signed-off-by: names are not matching. They should be same. > --- > --- a/