On Tue, 2013-07-23 at 09:42 -0700, Joe Perches wrote:
> On Tue, 2013-07-23 at 19:51 +0800, Lilis Iskandar wrote:
> > Fixed spacing/tabs issues that were found using checkpatch.
>
> Hi Lilis.
>
> It'd be better to change the email subject to
> "[PATCH v2] etc..." to show that's it's a new
> versio
On Tue, 2013-07-23 at 19:51 +0800, Lilis Iskandar wrote:
> Fixed spacing/tabs issues that were found using checkpatch.
Hi Lilis.
It'd be better to change the email subject to
"[PATCH v2] etc..." to show that's it's a new
version of the patch.
It's also useful to add a note or two like
"git diff
On Tue, Jul 23, 2013 at 07:51:02PM +0800, Lilis Iskandar wrote:
> Fixed spacing/tabs issues that were found using checkpatch.
>
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://
Fixed spacing/tabs issues that were found using checkpatch.
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/Qos.c | 538 +++---
1 file changed, 269 insertions(+), 269 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
in
On Tue, Jul 23, 2013 at 06:10:41PM +0800, Lilis Iskandar wrote:
> Hi Dan,
>
> I have already accepted my fate when I submitted the patch. Though it's
> really great that I receive a response so fast :)
>
> Regarding the braces, I thought it would be more readable that way
> because of the long co
Hi Dan,
I have already accepted my fate when I submitted the patch. Though it's
really great that I receive a response so fast :)
Regarding the braces, I thought it would be more readable that way
because of the long code wrapping inside the "if" parameter. I'll fix it
and send the patches again
Hi hi,
Welcome first time submitter newbie. :) The tradition is to reject
first time code submissions in the meanest and grumpiest way
possible.
On Tue, Jul 23, 2013 at 05:20:29PM +0800, Lilis Iskandar wrote:
> >From a2f8b299baee0e075d548d2bbf77619373035446 Mon Sep 17 00:00:00 2001
> From: Lili
