Re: Re: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of devm_kcalloc()

2022-04-01 Thread Andy Shevchenko
On Fri, Apr 1, 2022 at 6:06 AM unSimple wrote: > > The main consideration of the 'continue' in the patch is that those > statements are inner a loop. > > The next allocation may be successful so I think it is better to use > 'continue' here. Please, do not top-post! What you explained is logi

Re: Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-02 Thread Kees Cook
On Thu, Apr 01, 2021 at 04:09:57PM +0200, Greg KH wrote: > On Thu, Apr 01, 2021 at 08:28:02PM +0800, Yongji Xie wrote: > > On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote: > > > > > > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > > > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH > > > >

Re: Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 08:28:02PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > > > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie

Re: Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > > > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH > > > > wrote: >

Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > > > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji

Re: Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > > > Use receive_fd() to receive file from another process ins

Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 6:40 PM Christian Brauner wrote: > > On Thu, Apr 01, 2021 at 11:54:45AM +0200, Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > > Use receive_fd() to receive file from another process instead of > > > combination of get_unused_fd_flags() and

Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Greg KH
On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote: > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > > Use receive_fd() to receive file from another process instead of > > > combination of get_unused_fd_flags() and fd_i

Re: Re: [PATCH 1/2] file: Export receive_fd() to modules

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 5:52 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:31PM +0800, Xie Yongji wrote: > > Export receive_fd() so that some modules can use > > it to pass file descriptor across processes without > > missing any security stuffs. > > > > Signed-off-by: Xie Yongji > > --- > >

Re: Re: [PATCH 2/2] binder: Use receive_fd() to receive file from another process

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote: > > Use receive_fd() to receive file from another process instead of > > combination of get_unused_fd_flags() and fd_install(). This simplifies > > the logic and also makes sure we don't m

Re: Re: [PATCH 0/2] Export receive_fd() to modules and do some cleanups

2021-04-01 Thread Yongji Xie
On Thu, Apr 1, 2021 at 5:53 PM Greg KH wrote: > > On Thu, Apr 01, 2021 at 05:09:30PM +0800, Xie Yongji wrote: > > This series starts from Christian's comments on the series[1]. > > We'd like to export receive_fd() which can not only be used by > > our module in the series[1] but also allow further

Re: Re: [PATCH v2] staging: rtl8192u: remove extra lines

2021-03-16 Thread gregkh
On Tue, Mar 16, 2021 at 06:03:17PM +0800, 赵晓 wrote: > This email message is intended only for the use of the individual or entity > who > /which is the intended recipient and may contain information that is > privileged > or confidential. If you are not the intended recipient, you are hereby > n

Re: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
a...@googlemail.com, gre...@linuxfoundation.org, de...@driverdev.osuosl.org, linux-ker...@vger.kernel.org > 主题: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value > > On Thu, Dec 10, 2020 at 11:05:34PM +0800, shaojie.d...@isrc.iscas.ac.cn wrote: > > Hi > > &g

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread Dan Carpenter
On Thu, Dec 10, 2020 at 11:05:34PM +0800, shaojie.d...@isrc.iscas.ac.cn wrote: > Hi > > > > > This function should not be calling register_netdev(). What does that > > have to do with firmware? It should also not free_netdev() because > > that will just lead to a use after free in the caller. >

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi Thanks ! I will modify sign name correctly later Sorry to say that I have no rtl8712 hardware, so that I could not test it. From Dan Carpenter's email reply, "free_netdev(adapter->pnetdev)" function may cause use after free issue So that I reply email to ensure if this return value should b

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi > > This function should not be calling register_netdev(). What does that > have to do with firmware? It should also not free_netdev() because > that will just lead to a use after free in the caller. > --> check code history author changed synchronous firmware loading to asynchronous firmw

Re: Re: [PATCH v3] media: cedrus: Add support for VP8 decoding

2020-11-26 Thread Ezequiel Garcia
On Fri, 2020-11-27 at 00:40 +0100, Jernej Škrabec wrote: > Hi! > > Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a): > > Hi Jernej, Emmanuel, > > > > Thanks for the patch. > > > > On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec wrote: > > > VP8 in Cedrus shares same e

Re: Re: [PATCH v3] media: cedrus: Add support for VP8 decoding

2020-11-26 Thread Jernej Škrabec
Hi! Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a): > Hi Jernej, Emmanuel, > > Thanks for the patch. > > On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec wrote: > > VP8 in Cedrus shares same engine as H264. > > > > Note that it seems necessary to call bitstream pars

Re: Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode

2020-07-27 Thread dinghao . liu
> I review things in the order that they appear in my inbox so I hadn't > seen Greg and Larry's comments. You've now stumbled into an area of > politics where you have conflicting reviews... :P Fortunately, we're > all of us reasonable people. > > I think your patch is correct in that it is wha

Re: Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode

2020-07-27 Thread dinghao . liu
> > Yes, in this routine, it would be possible for authmode to not be set; > however, > later code only compares it to either _WPA_IE_ID_ or _WPA2_IE_ID_. It is > never > used in a way that an unset value could make the program flow be different by > arbitrarily setting the value to zero. Thu

Re: Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c

2020-07-15 Thread Dan Carpenter
On Wed, Jul 15, 2020 at 06:45:21PM +0800, Zhao wrote: > At 2020-07-15 17:04:06, "Joe Perches" wrote: > >On Wed, 2020-07-15 at 11:37 +0300, Dan Carpenter wrote: > >> On Wed, Jul 15, 2020 at 09:57:55AM +0200, Greg KH wrote: > >> > On Wed, Jul 15, 2020 at 12:24:22AM -0700, Joe Perches wrote: > >> > >

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-28 Thread Rafael J. Wysocki
On Thu, May 28, 2020 at 2:08 PM Dan Carpenter wrote: > > On Fri, May 22, 2020 at 04:43:12PM +0200, Thierry Reding wrote: > > On Fri, May 22, 2020 at 04:23:18PM +0300, Dan Carpenter wrote: > > > On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote: > > > > On Thu, May 21, 2020 at 08:39:02

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-28 Thread Dan Carpenter
On Fri, May 22, 2020 at 04:43:12PM +0200, Thierry Reding wrote: > On Fri, May 22, 2020 at 04:23:18PM +0300, Dan Carpenter wrote: > > On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote: > > > On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote: > > > > On Thu, May 21, 2020 at 0

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-22 Thread Thierry Reding
On Fri, May 22, 2020 at 04:23:18PM +0300, Dan Carpenter wrote: > On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote: > > On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote: > > > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > > > > On Thu, May 21, 2020 a

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-22 Thread Dan Carpenter
On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote: > On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote: > > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > > > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter > > > wrote: > > > > > > > > On Thu, May 21,

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-22 Thread Thierry Reding
On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote: > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter > > wrote: > > > > > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > > > > Hi, Dan, >

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Dan Carpenter
On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter > wrote: > > > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > > > Hi, Dan, > > > > > > I agree the best solution is to fix __pm_runtime_resume(). But th

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Rafael J. Wysocki
On Thu, May 21, 2020 at 11:15 AM Dan Carpenter wrote: > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > > Hi, Dan, > > > > I agree the best solution is to fix __pm_runtime_resume(). But there are > > also > > many cases that assume pm_runtime_get_sync() will change PM

Re: Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread dinghao . liu
Sorry, I misunderstood your idea before. A new function is the best solution for this problem. Regards, Dinghao "Dan Carpenter" 写道: > On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote: > > We need to make sure if pm_runtime_get_sync() is designed wi

Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Dan Carpenter
On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote: > We need to make sure if pm_runtime_get_sync() is designed with > such behavior before modifying it. > > I received a response from Rafael when I commited a similar patch: > https://lkml.org/lkml/2020/5/20/1100 > It seems t

Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread dinghao . liu
We need to make sure if pm_runtime_get_sync() is designed with such behavior before modifying it. I received a response from Rafael when I commited a similar patch: https://lkml.org/lkml/2020/5/20/1100 It seems that this behavior is intentional and needs to be kept. Regards, Dinghao "Dan Carpe

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Dan Carpenter
On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > Hi, Dan, > > I agree the best solution is to fix __pm_runtime_resume(). But there are also > many cases that assume pm_runtime_get_sync() will change PM usage > counter on error. According to my static analysis results, th

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-20 Thread dinghao . liu
Hi, Dan, I agree the best solution is to fix __pm_runtime_resume(). But there are also many cases that assume pm_runtime_get_sync() will change PM usage counter on error. According to my static analysis results, the number of these "right" cases are larger. Adjusting __pm_runtime_resume() direc

Re: Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-09-17 Thread Okash Khawaja
Ah it looks like the spaces after Description: need to be converted into tabs. Thanks, Okash On Tue, Sep 17, 2019 at 10:35 PM Okash Khawaja wrote: > > Hi Greg, > > You're right, I got none of those emails. Thanks. Is it all taken care of? > > Best regards, > Okash > > On Tue, Sep 17, 2019 at 4:5

Re: Re: [PATCH V3] binder: ipc namespace support for android binder(Internet mail)

2018-11-09 Thread Todd Kjos
On Fri, Nov 9, 2018 at 9:43 PM chouryzhou(周威) wrote: > > > > > > > If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists, it > > > will be a static > > > reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by > > > me) with > > > no namespace-ization. You will get

Re: Re: [PATCH V3] binder: ipc namespace support for android binder(Internet mail)

2018-11-09 Thread 周威
> > > > If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists,  it will > > be a static > > reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by > > me) with > > no namespace-ization. You will get the same one in all processes, > > everything is > > the same as  w

Re: Re: [PATCH V3] binder: ipc namespace support for android binder(Internet mail)

2018-11-09 Thread Todd Kjos
On Fri, Nov 9, 2018 at 8:43 PM chouryzhou(周威) wrote: > > If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists, it will > be a static > reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by me) > with > no namespace-ization. You will get the same one in all proce

Re: Re: [PATCH V3] binder: ipc namespace support for android binder(Internet mail)

2018-11-09 Thread 周威
> > > I still don't understand the dependencies on SYSVIPC or POSIX_MQUEUE. > > > It seems like this mechanism would work even if both are disabled -- > > > as long as IPC_NS is enabled. Seems cleaner to change init/Kconfig and > > > allow IPC_NS if CONFIG_ANDROID_BINDER_IPC and change this line t

Re: Re: [PATCH V3] binder: ipc namespace support for android binder

2018-11-09 Thread Todd Kjos
On Fri, Nov 9, 2018 at 7:09 PM chouryzhou(周威) wrote: > > > > > I still don't understand the dependencies on SYSVIPC or POSIX_MQUEUE. > > It seems like this mechanism would work even if both are disabled -- > > as long as IPC_NS is enabled. Seems cleaner to change init/Kconfig and > > allow IPC_NS

Re: Re: [PATCH V3] binder: ipc namespace support for android binder

2018-11-09 Thread 周威
>  > I still don't understand the dependencies on SYSVIPC or POSIX_MQUEUE. > It seems like this mechanism would work even if both are disabled -- > as long as IPC_NS is enabled. Seems cleaner to change init/Kconfig and > allow IPC_NS if CONFIG_ANDROID_BINDER_IPC and change this line to > "#ifndef C

Re: Re: [PATCH] staging: media: davinci_vpfe: add error handling on kmalloc failure

2018-03-19 Thread Dan Carpenter
On Mon, Mar 19, 2018 at 01:24:57PM +0900, Ji-Hun Kim wrote: > > 1294 } else if (to && !from && size) { > > 1295 rval = module_if->set(ipipe, NULL); > > 1296 if (rval) > > 1297

Re: Re: [PATCH] staging: media: davinci_vpfe: add error handling on kmalloc failure

2018-03-18 Thread Ji-Hun Kim
On Fri, Mar 16, 2018 at 11:32:34AM +0300, Dan Carpenter wrote: > On Fri, Mar 16, 2018 at 01:58:23PM +0900, Ji-Hun Kim wrote: > > There is no failure checking on the param value which will be allocated > > memory by kmalloc. Add a null pointer checking statement. Then goto error: > > and return -ENO

Re: Re: [PATCH] staging: vc04_services: Fix checkpatch.pl warnings

2018-01-14 Thread Sidong Yang
Hi Stefan, I'm really glad to review my commit! I think that your suggestion that changes subject is good. > i'm okay with the changes, but the subject is too general. We get fixes for > checkpach warning nearly once a week. Suggestion: > > staging: vchiq_version: Use tabs for identation > >

Re: Re: [PATCH] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

2017-06-17 Thread Antoine BLIN
Hi, My real name is Antoine BLIN. I'm sorry for the mistake ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Joe Perches
On Thu, 2016-10-13 at 18:49 +0200, Greg KH wrote: > On Thu, Oct 13, 2016 at 09:37:23AM -0700, Joe Perches wrote: > > On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote: > > > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > > > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wro

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 09:37:23AM -0700, Joe Perches wrote: > On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote: > > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > > > > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikh

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Joe Perches
On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote: > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > > > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > > > > Function definitions arguments should also

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > > > Function definitions arguments should also have an identifier name as > > > reported by checkpatch.

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Mikhail Golubev
On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > > Function definitions arguments should also have an identifier name as > > reported by checkpatch.pl. > > Please wrap your changelog comments at 72 columns. > > > > > S

Re: Re: [PATCH] staging: slicoss: replacement of goto statements

2016-06-08 Thread Greg KH
On Wed, Jun 08, 2016 at 11:28:11AM -0500, Jaime Arrocha wrote: > > On Wed, 08 Jun 2016 10:49:47 -0500 Greg KH > wrote > > > On Wed, Jun 08, 2016 at 08:46:06AM -0500, Jaime Arrocha wrote: > > > From: Jaime Arrocha > > > > > > Replaced deprecated goto statements. > > > >

Re: Re: [PATCH] staging: slicoss: replacement of goto statements

2016-06-08 Thread Jaime Arrocha
On Wed, 08 Jun 2016 10:49:47 -0500 Greg KH wrote > On Wed, Jun 08, 2016 at 08:46:06AM -0500, Jaime Arrocha wrote: > > From: Jaime Arrocha > > > > Replaced deprecated goto statements. > > Since when is 'goto' deprecated? > > Were you able to test these changes? >

RE: RE

2016-03-19 Thread Robert
Did you get my previous message i sent to you? when and what time can i call you? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Re: [PATCH v3] staging/android/ion : fix a race condition in the ion driver

2016-03-01 Thread EunTaik Lee
> From: Laura Abbott [mailto:labb...@redhat.com] > Sent: Friday, February 26, 2016 7:12 AM > To: eun.taik@samsung.com; gre...@linuxfoundation.org; a...@android.com; > riandr...@android.com; sumit.sem...@linaro.org; dan.carpen...@oracle.com; > Rohit Kumar ; sri...@marirs.net.in; shawn.lin@rock-

Re: Re: [PATCH v2] staging/android/ion : fix a race condition in the ion driver

2016-02-23 Thread EunTaik Lee
> From: Laura Abbott [mailto:labb...@redhat.com] > Sent: Saturday, February 20, 2016 5:09 AM > To: eun.taik@samsung.com; gre...@linuxfoundation.org; a...@android.com; > riandr...@android.com; sumit.sem...@linaro.org; dan.carpen...@oracle.com; > Rohit Kumar ; sri...@marirs.net.in; shawn.lin@roc

Re: Re: [RFC PATCH] staging/android/ion : fix a race condition in the ion driver

2016-02-18 Thread EunTaik Lee
2016-02-18 3:54 GMT+09:00 Laura Abbott : > On 02/16/2016 10:32 PM, EunTaik Lee wrote: >> There was a use-after-free problem in the ion driver. >> >> The problem is detected as an unaligned access in the >> spin lock functions since it uses load exclusive >> instruction. In some cases it corrupts

Re: Re: [PATCH] staging: gdm724: adding kernel endianness header

2015-05-09 Thread Jaime Arrocha
On Sat, 09 May 2015 05:59:40 -0500 Dan Carpenter wrote > On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote: > > >From TODO list: remove test for host endian > > Included header to gather information about host endianness. > > Please let me know if the code additio

Re: Re: [PATCH 1/1] [ion]: system-heap use PAGE_ALLOC_COSTLY_ORDER for high order

2014-10-07 Thread Colin Cross
;> ; "john.stu...@linaro.org" >> ; "rebe...@android.com" ; >> "de...@driverdev.osuosl.org" ; >> "linux-ker...@vger.kernel.org" ; IQBAL SHAREEF >> ; "pintu_agar...@yahoo.com" >> ; Vishnu Pratap Singh ; >> "c

RE: Re: [PATCH 1/1] [ion]: system-heap use PAGE_ALLOC_COSTLY_ORDER for high order

2014-10-07 Thread PINTU KUMAR
d.com" ; > "de...@driverdev.osuosl.org" ; > "linux-ker...@vger.kernel.org" ; IQBAL SHAREEF > ; "pintu_agar...@yahoo.com" ; > Vishnu Pratap Singh ; "c...@samsung.com" > > Sent: Monday, 6 October 2014 11:01 PM > Subject: Re: Re: [PATCH 1/1

Re: Re: [PATCH 1/1] [ion]: system-heap use PAGE_ALLOC_COSTLY_ORDER for high order

2014-10-06 Thread Colin Cross
On Mon, Oct 6, 2014 at 9:26 AM, PINTU KUMAR wrote: > > Hi, > > > > From: Laura Abbott > >To: Heesub Shin ; Pintu Kumar > >; a...@linux-foundation.org; > >gre...@linuxfoundation.org; john.stu...@linaro.org; rebe...@android.com; > >ccr...@android.com; de...@driver

Re: Re: [PATCH 1/1] [ion]: system-heap use PAGE_ALLOC_COSTLY_ORDER for high order

2014-10-06 Thread PINTU KUMAR
Hi, > > From: Laura Abbott >To: Heesub Shin ; Pintu Kumar ; >a...@linux-foundation.org; gre...@linuxfoundation.org; john.stu...@linaro.org; >rebe...@android.com; ccr...@android.com; de...@driverdev.osuosl.org; >linux-ker...@vger.kernel.org >Cc: iqbal@samsung

Re: Re: product inquiry

2014-01-08 Thread Jose Benitez
Hello Sales Manager, Thank for the response.Please find attached especificaзгo for profoma invoice. Kindly revisгo and send final quote with best prices so we send PO imediatamente. Any pregunta, please ask. Saludos, Jose Benitez Anastacio Bustamante 76 Int.8 Francisco Sarabia,C.P.45235, Zapopa

Re: Re: [PATCH 2/2] staging: Add NULL checks against return values ofskb_clone() and dev_alloc_skb()

2013-10-28 Thread Greg Kroah-Hartman
On Mon, Oct 28, 2013 at 08:21:48AM -0700, Greg Kroah-Hartman wrote: > On Mon, Oct 28, 2013 at 12:12:17PM +0800, rucsoftsec wrote: > > By the way, the bug is found by our group, so I typed the name of it. Does > > it > > OK? > > No, that is not allowed. To expand on this, kernel development is do

Re: Re: [PATCH 2/2] staging: Add NULL checks against return values ofskb_clone() and dev_alloc_skb()

2013-10-28 Thread Greg Kroah-Hartman
On Mon, Oct 28, 2013 at 12:12:17PM +0800, rucsoftsec wrote: Please do not send HTML email, the mailing lists delete it. > I am so sorry! I made something wrong when genenrating the patch. I will do it > again soon later. Your other patches are also incorrect, sorry. > By the way, the bug is fou

Re: Re: [PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value afterdoing dev_alloc_skb

2013-08-18 Thread Dan Carpenter
On Mon, Aug 19, 2013 at 09:15:15AM +0800, rucsoftsec wrote: > I have read that file. But the trouble is that I was not sure > whether it is a bug or not. So I report it to BugZilla, and wait > for further confirmation. > Thank you all the same! > If you send it to kernel-janitors we will be happy

Re: Re: [PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value afterdoing dev_alloc_skb

2013-08-18 Thread Greg KH
On Mon, Aug 19, 2013 at 09:15:15AM +0800, rucsoftsec wrote: > I have read that file. But the trouble is that I was not sure whether it is a > bug or not. So I report it to BugZilla, and wait for further confirmation. Don't worry about bugzilla, please send us a patch through email so we can accept

Re: Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Michal Hocko
On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote: > > On Wed 24-07-13 12:02:35, Michal Hocko wrote: > > > I have posted a similar fix quite some time ago and I guess Greg should > > > already have it. > > > > For re

Re: Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote: > On Wed 24-07-13 12:02:35, Michal Hocko wrote: > > I have posted a similar fix quite some time ago and I guess Greg should > > already have it. > > For reference https://lkml.org/lkml/2013/6/26/410 There was a reply from Greg: