On Fri, Apr 1, 2022 at 6:06 AM unSimple wrote:
>
> The main consideration of the 'continue' in the patch is that those
> statements are inner a loop.
>
> The next allocation may be successful so I think it is better to use
> 'continue' here.
Please, do not top-post!
What you explained is logi
On Thu, Apr 01, 2021 at 04:09:57PM +0200, Greg KH wrote:
> On Thu, Apr 01, 2021 at 08:28:02PM +0800, Yongji Xie wrote:
> > On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote:
> > >
> > > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote:
> > > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH
> > > >
On Thu, Apr 01, 2021 at 08:28:02PM +0800, Yongji Xie wrote:
> On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote:
> >
> > On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote:
> > > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote:
> > > >
> > > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie
On Thu, Apr 1, 2021 at 7:33 PM Greg KH wrote:
>
> On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote:
> > On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote:
> > >
> > > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote:
> > > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH
> > > > wrote:
>
On Thu, Apr 01, 2021 at 07:29:45PM +0800, Yongji Xie wrote:
> On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote:
> >
> > On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote:
> > > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote:
> > > >
> > > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji
On Thu, Apr 1, 2021 at 6:42 PM Greg KH wrote:
>
> On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote:
> > On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote:
> > >
> > > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote:
> > > > Use receive_fd() to receive file from another process ins
On Thu, Apr 1, 2021 at 6:40 PM Christian Brauner
wrote:
>
> On Thu, Apr 01, 2021 at 11:54:45AM +0200, Greg KH wrote:
> > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote:
> > > Use receive_fd() to receive file from another process instead of
> > > combination of get_unused_fd_flags() and
On Thu, Apr 01, 2021 at 06:12:51PM +0800, Yongji Xie wrote:
> On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote:
> >
> > On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote:
> > > Use receive_fd() to receive file from another process instead of
> > > combination of get_unused_fd_flags() and fd_i
On Thu, Apr 1, 2021 at 5:52 PM Greg KH wrote:
>
> On Thu, Apr 01, 2021 at 05:09:31PM +0800, Xie Yongji wrote:
> > Export receive_fd() so that some modules can use
> > it to pass file descriptor across processes without
> > missing any security stuffs.
> >
> > Signed-off-by: Xie Yongji
> > ---
> >
On Thu, Apr 1, 2021 at 5:54 PM Greg KH wrote:
>
> On Thu, Apr 01, 2021 at 05:09:32PM +0800, Xie Yongji wrote:
> > Use receive_fd() to receive file from another process instead of
> > combination of get_unused_fd_flags() and fd_install(). This simplifies
> > the logic and also makes sure we don't m
On Thu, Apr 1, 2021 at 5:53 PM Greg KH wrote:
>
> On Thu, Apr 01, 2021 at 05:09:30PM +0800, Xie Yongji wrote:
> > This series starts from Christian's comments on the series[1].
> > We'd like to export receive_fd() which can not only be used by
> > our module in the series[1] but also allow further
On Tue, Mar 16, 2021 at 06:03:17PM +0800, 赵晓 wrote:
> This email message is intended only for the use of the individual or entity
> who
> /which is the intended recipient and may contain information that is
> privileged
> or confidential. If you are not the intended recipient, you are hereby
> n
a...@googlemail.com,
gre...@linuxfoundation.org, de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
> 主题: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value
>
> On Thu, Dec 10, 2020 at 11:05:34PM +0800, shaojie.d...@isrc.iscas.ac.cn
wrote:
> > Hi
> >
&g
On Thu, Dec 10, 2020 at 11:05:34PM +0800, shaojie.d...@isrc.iscas.ac.cn wrote:
> Hi
>
> >
> > This function should not be calling register_netdev(). What does that
> > have to do with firmware? It should also not free_netdev() because
> > that will just lead to a use after free in the caller.
>
Hi
Thanks ! I will modify sign name correctly later
Sorry to say that I have no rtl8712 hardware, so that I could not test it.
From Dan Carpenter's email reply, "free_netdev(adapter->pnetdev)" function
may cause use after free issue
So that I reply email to ensure if this return value should b
Hi
>
> This function should not be calling register_netdev(). What does that
> have to do with firmware? It should also not free_netdev() because
> that will just lead to a use after free in the caller.
>
--> check code history author changed synchronous
firmware loading to asynchronous firmw
On Fri, 2020-11-27 at 00:40 +0100, Jernej Škrabec wrote:
> Hi!
>
> Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a):
> > Hi Jernej, Emmanuel,
> >
> > Thanks for the patch.
> >
> > On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec wrote:
> > > VP8 in Cedrus shares same e
Hi!
Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a):
> Hi Jernej, Emmanuel,
>
> Thanks for the patch.
>
> On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec wrote:
> > VP8 in Cedrus shares same engine as H264.
> >
> > Note that it seems necessary to call bitstream pars
> I review things in the order that they appear in my inbox so I hadn't
> seen Greg and Larry's comments. You've now stumbled into an area of
> politics where you have conflicting reviews... :P Fortunately, we're
> all of us reasonable people.
>
> I think your patch is correct in that it is wha
>
> Yes, in this routine, it would be possible for authmode to not be set;
> however,
> later code only compares it to either _WPA_IE_ID_ or _WPA2_IE_ID_. It is
> never
> used in a way that an unset value could make the program flow be different by
> arbitrarily setting the value to zero. Thu
On Wed, Jul 15, 2020 at 06:45:21PM +0800, Zhao wrote:
> At 2020-07-15 17:04:06, "Joe Perches" wrote:
> >On Wed, 2020-07-15 at 11:37 +0300, Dan Carpenter wrote:
> >> On Wed, Jul 15, 2020 at 09:57:55AM +0200, Greg KH wrote:
> >> > On Wed, Jul 15, 2020 at 12:24:22AM -0700, Joe Perches wrote:
> >> > >
On Thu, May 28, 2020 at 2:08 PM Dan Carpenter wrote:
>
> On Fri, May 22, 2020 at 04:43:12PM +0200, Thierry Reding wrote:
> > On Fri, May 22, 2020 at 04:23:18PM +0300, Dan Carpenter wrote:
> > > On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote:
> > > > On Thu, May 21, 2020 at 08:39:02
On Fri, May 22, 2020 at 04:43:12PM +0200, Thierry Reding wrote:
> On Fri, May 22, 2020 at 04:23:18PM +0300, Dan Carpenter wrote:
> > On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote:
> > > On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote:
> > > > On Thu, May 21, 2020 at 0
On Fri, May 22, 2020 at 04:23:18PM +0300, Dan Carpenter wrote:
> On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote:
> > On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote:
> > > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote:
> > > > On Thu, May 21, 2020 a
On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote:
> On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote:
> > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote:
> > > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter
> > > wrote:
> > > >
> > > > On Thu, May 21,
On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote:
> On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote:
> > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter
> > wrote:
> > >
> > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote:
> > > > Hi, Dan,
>
On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote:
> On Thu, May 21, 2020 at 11:15 AM Dan Carpenter
> wrote:
> >
> > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote:
> > > Hi, Dan,
> > >
> > > I agree the best solution is to fix __pm_runtime_resume(). But th
On Thu, May 21, 2020 at 11:15 AM Dan Carpenter wrote:
>
> On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote:
> > Hi, Dan,
> >
> > I agree the best solution is to fix __pm_runtime_resume(). But there are
> > also
> > many cases that assume pm_runtime_get_sync() will change PM
Sorry, I misunderstood your idea before. A new function is
the best solution for this problem.
Regards,
Dinghao
"Dan Carpenter" 写道:
> On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote:
> > We need to make sure if pm_runtime_get_sync() is designed wi
On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote:
> We need to make sure if pm_runtime_get_sync() is designed with
> such behavior before modifying it.
>
> I received a response from Rafael when I commited a similar patch:
> https://lkml.org/lkml/2020/5/20/1100
> It seems t
We need to make sure if pm_runtime_get_sync() is designed with
such behavior before modifying it.
I received a response from Rafael when I commited a similar patch:
https://lkml.org/lkml/2020/5/20/1100
It seems that this behavior is intentional and needs to be kept.
Regards,
Dinghao
"Dan Carpe
On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote:
> Hi, Dan,
>
> I agree the best solution is to fix __pm_runtime_resume(). But there are also
> many cases that assume pm_runtime_get_sync() will change PM usage
> counter on error. According to my static analysis results, th
Hi, Dan,
I agree the best solution is to fix __pm_runtime_resume(). But there are also
many cases that assume pm_runtime_get_sync() will change PM usage
counter on error. According to my static analysis results, the number of these
"right" cases are larger. Adjusting __pm_runtime_resume() direc
Ah it looks like the spaces after Description: need to be converted into tabs.
Thanks,
Okash
On Tue, Sep 17, 2019 at 10:35 PM Okash Khawaja wrote:
>
> Hi Greg,
>
> You're right, I got none of those emails. Thanks. Is it all taken care of?
>
> Best regards,
> Okash
>
> On Tue, Sep 17, 2019 at 4:5
On Fri, Nov 9, 2018 at 9:43 PM chouryzhou(周威) wrote:
>
> > >
> > > If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists, it
> > > will be a static
> > > reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by
> > > me) with
> > > no namespace-ization. You will get
> >
> > If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists, it will
> > be a static
> > reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by
> > me) with
> > no namespace-ization. You will get the same one in all processes,
> > everything is
> > the same as w
On Fri, Nov 9, 2018 at 8:43 PM chouryzhou(周威) wrote:
>
> If IPC_NS is disabled, "current-nsporxy->ipc_ns" will also exists, it will
> be a static
> reference of "init_ipc_ns" (in ipc/msgutil.c, not defined in binder.c by me)
> with
> no namespace-ization. You will get the same one in all proce
> > > I still don't understand the dependencies on SYSVIPC or POSIX_MQUEUE.
> > > It seems like this mechanism would work even if both are disabled --
> > > as long as IPC_NS is enabled. Seems cleaner to change init/Kconfig and
> > > allow IPC_NS if CONFIG_ANDROID_BINDER_IPC and change this line t
On Fri, Nov 9, 2018 at 7:09 PM chouryzhou(周威) wrote:
>
> >
> > I still don't understand the dependencies on SYSVIPC or POSIX_MQUEUE.
> > It seems like this mechanism would work even if both are disabled --
> > as long as IPC_NS is enabled. Seems cleaner to change init/Kconfig and
> > allow IPC_NS
>
> I still don't understand the dependencies on SYSVIPC or POSIX_MQUEUE.
> It seems like this mechanism would work even if both are disabled --
> as long as IPC_NS is enabled. Seems cleaner to change init/Kconfig and
> allow IPC_NS if CONFIG_ANDROID_BINDER_IPC and change this line to
> "#ifndef C
On Mon, Mar 19, 2018 at 01:24:57PM +0900, Ji-Hun Kim wrote:
> > 1294 } else if (to && !from && size) {
> > 1295 rval = module_if->set(ipipe, NULL);
> > 1296 if (rval)
> > 1297
On Fri, Mar 16, 2018 at 11:32:34AM +0300, Dan Carpenter wrote:
> On Fri, Mar 16, 2018 at 01:58:23PM +0900, Ji-Hun Kim wrote:
> > There is no failure checking on the param value which will be allocated
> > memory by kmalloc. Add a null pointer checking statement. Then goto error:
> > and return -ENO
Hi Stefan,
I'm really glad to review my commit!
I think that your suggestion that changes subject is good.
> i'm okay with the changes, but the subject is too general. We get fixes for
> checkpach warning nearly once a week. Suggestion:
>
> staging: vchiq_version: Use tabs for identation
>
>
Hi,
My real name is Antoine BLIN.
I'm sorry for the mistake
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, 2016-10-13 at 18:49 +0200, Greg KH wrote:
> On Thu, Oct 13, 2016 at 09:37:23AM -0700, Joe Perches wrote:
> > On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote:
> > > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote:
> > > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wro
On Thu, Oct 13, 2016 at 09:37:23AM -0700, Joe Perches wrote:
> On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote:
> > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote:
> > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote:
> > > > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikh
On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote:
> On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote:
> > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote:
> > > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote:
> > > > Function definitions arguments should also
On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote:
> On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote:
> > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote:
> > > Function definitions arguments should also have an identifier name as
> > > reported by checkpatch.
On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote:
> On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote:
> > Function definitions arguments should also have an identifier name as
> > reported by checkpatch.pl.
>
> Please wrap your changelog comments at 72 columns.
>
> >
> > S
On Wed, Jun 08, 2016 at 11:28:11AM -0500, Jaime Arrocha wrote:
>
> On Wed, 08 Jun 2016 10:49:47 -0500 Greg KH
> wrote
>
> > On Wed, Jun 08, 2016 at 08:46:06AM -0500, Jaime Arrocha wrote:
> > > From: Jaime Arrocha
> > >
> > > Replaced deprecated goto statements.
> >
> >
On Wed, 08 Jun 2016 10:49:47 -0500 Greg KH
wrote
> On Wed, Jun 08, 2016 at 08:46:06AM -0500, Jaime Arrocha wrote:
> > From: Jaime Arrocha
> >
> > Replaced deprecated goto statements.
>
> Since when is 'goto' deprecated?
>
> Were you able to test these changes?
>
Did you get my previous message i sent to you? when and what time can i call
you?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> From: Laura Abbott [mailto:labb...@redhat.com]
> Sent: Friday, February 26, 2016 7:12 AM
> To: eun.taik@samsung.com; gre...@linuxfoundation.org; a...@android.com;
> riandr...@android.com; sumit.sem...@linaro.org; dan.carpen...@oracle.com;
> Rohit Kumar ; sri...@marirs.net.in; shawn.lin@rock-
> From: Laura Abbott [mailto:labb...@redhat.com]
> Sent: Saturday, February 20, 2016 5:09 AM
> To: eun.taik@samsung.com; gre...@linuxfoundation.org; a...@android.com;
> riandr...@android.com; sumit.sem...@linaro.org; dan.carpen...@oracle.com;
> Rohit Kumar ; sri...@marirs.net.in; shawn.lin@roc
2016-02-18 3:54 GMT+09:00 Laura Abbott :
> On 02/16/2016 10:32 PM, EunTaik Lee wrote:
>> There was a use-after-free problem in the ion driver.
>>
>> The problem is detected as an unaligned access in the
>> spin lock functions since it uses load exclusive
>> instruction. In some cases it corrupts
On Sat, 09 May 2015 05:59:40 -0500 Dan Carpenter
wrote
> On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote:
> > >From TODO list: remove test for host endian
> > Included header to gather information about host endianness.
> > Please let me know if the code additio
;> ; "john.stu...@linaro.org"
>> ; "rebe...@android.com" ;
>> "de...@driverdev.osuosl.org" ;
>> "linux-ker...@vger.kernel.org" ; IQBAL SHAREEF
>> ; "pintu_agar...@yahoo.com"
>> ; Vishnu Pratap Singh ;
>> "c
d.com" ;
> "de...@driverdev.osuosl.org" ;
> "linux-ker...@vger.kernel.org" ; IQBAL SHAREEF
> ; "pintu_agar...@yahoo.com" ;
> Vishnu Pratap Singh ; "c...@samsung.com"
>
> Sent: Monday, 6 October 2014 11:01 PM
> Subject: Re: Re: [PATCH 1/1
On Mon, Oct 6, 2014 at 9:26 AM, PINTU KUMAR wrote:
>
> Hi,
> >
> > From: Laura Abbott
> >To: Heesub Shin ; Pintu Kumar
> >; a...@linux-foundation.org;
> >gre...@linuxfoundation.org; john.stu...@linaro.org; rebe...@android.com;
> >ccr...@android.com; de...@driver
Hi,
>
> From: Laura Abbott
>To: Heesub Shin ; Pintu Kumar ;
>a...@linux-foundation.org; gre...@linuxfoundation.org; john.stu...@linaro.org;
>rebe...@android.com; ccr...@android.com; de...@driverdev.osuosl.org;
>linux-ker...@vger.kernel.org
>Cc: iqbal@samsung
Hello Sales Manager,
Thank for the response.Please find attached especificaзгo for profoma invoice.
Kindly revisгo and send final quote with best prices so we send PO
imediatamente.
Any pregunta, please ask.
Saludos,
Jose Benitez
Anastacio Bustamante 76 Int.8
Francisco Sarabia,C.P.45235,
Zapopa
On Mon, Oct 28, 2013 at 08:21:48AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Oct 28, 2013 at 12:12:17PM +0800, rucsoftsec wrote:
> > By the way, the bug is found by our group, so I typed the name of it. Does
> > it
> > OK?
>
> No, that is not allowed.
To expand on this, kernel development is do
On Mon, Oct 28, 2013 at 12:12:17PM +0800, rucsoftsec wrote:
Please do not send HTML email, the mailing lists delete it.
> I am so sorry! I made something wrong when genenrating the patch. I will do it
> again soon later.
Your other patches are also incorrect, sorry.
> By the way, the bug is fou
On Mon, Aug 19, 2013 at 09:15:15AM +0800, rucsoftsec wrote:
> I have read that file. But the trouble is that I was not sure
> whether it is a bug or not. So I report it to BugZilla, and wait
> for further confirmation.
> Thank you all the same!
>
If you send it to kernel-janitors we will be happy
On Mon, Aug 19, 2013 at 09:15:15AM +0800, rucsoftsec wrote:
> I have read that file. But the trouble is that I was not sure whether it is a
> bug or not. So I report it to BugZilla, and wait for further confirmation.
Don't worry about bugzilla, please send us a patch through email so we
can accept
On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > > I have posted a similar fix quite some time ago and I guess Greg should
> > > already have it.
> >
> > For re
Hi,
On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > I have posted a similar fix quite some time ago and I guess Greg should
> > already have it.
>
> For reference https://lkml.org/lkml/2013/6/26/410
There was a reply from Greg:
67 matches
Mail list logo