RE: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

2016-01-08 Thread KY Srinivasan
.com; > jbottom...@parallels.com; h...@infradead.org; linux-s...@vger.kernel.org; > a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com; > martin.peter...@oracle.com; h...@suse.de > Cc: sta...@vger.kernel.org > Subject: Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error > ha

Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

2016-01-08 Thread James Bottomley
> > > linux- > > > > ker...@vger.kernel.org; de...@linuxdriverproject.org; > > > > oher...@suse.com; > > > > jbottom...@parallels.com; h...@infradead.org; > > > > linux-s...@vger.kernel.org; > > > > a...@canonical.com; vkuzn...@redha

RE: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

2016-01-08 Thread KY Srinivasan
.com; > jbottom...@parallels.com; h...@infradead.org; linux-s...@vger.kernel.org; > a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com; > martin.peter...@oracle.com; h...@suse.de > Cc: sta...@vger.kernel.org > Subject: Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error > ha

Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

2016-01-08 Thread James Bottomley
...@oracle.com; h...@suse.de > > Cc: sta...@vger.kernel.org > > Subject: Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the > > error > > handling function > > > > On Thu, 2016-01-07 at 16:40 -0800, K. Y. Srinivasan wrote: > > > The macro startget_

RE: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

2016-01-08 Thread KY Srinivasan
.com; > jbottom...@parallels.com; h...@infradead.org; linux-s...@vger.kernel.org; > a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com; > martin.peter...@oracle.com; h...@suse.de > Cc: sta...@vger.kernel.org > Subject: Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error &

Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

2016-01-07 Thread James Bottomley
On Thu, 2016-01-07 at 16:40 -0800, K. Y. Srinivasan wrote: > The macro startget_to_rport() can return NULL; handle that case > properly. OK, can we unwind why you think you could possibly need this? It would mean that fc_timed_out was called for a non-FC device, which was thought to be an impossi