Re: [PATCH] staging: ks7010: removed custom Michael MIC implementation.

2019-02-28 Thread Jeremy Sowden
On 2019-02-28, at 19:17:03 +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 28, 2019 at 11:15:56AM +, Jeremy Sowden wrote: > > Changed the driver to use the kernel's own implementation. > > > > Signed-off-by: Jeremy Sowden > > --- > > drivers/staging/ks7010/Makefile | 2 +- > > drivers/s

Re: [PATCH] staging: ks7010: removed custom Michael MIC implementation.

2019-02-28 Thread Greg Kroah-Hartman
On Thu, Feb 28, 2019 at 11:15:56AM +, Jeremy Sowden wrote: > Changed the driver to use the kernel's own implementation. > > Signed-off-by: Jeremy Sowden > --- > drivers/staging/ks7010/Makefile | 2 +- > drivers/staging/ks7010/TODO | 2 - > drivers/staging/ks7010/ks_hostif.c

[PATCH] staging: ks7010: removed custom Michael MIC implementation.

2019-02-28 Thread Jeremy Sowden
ard is inserted when booting - check what other upstream wireless mechanisms can be used instead of the custom ones here -- replace custom Michael MIC implementation with the kernel - implementation. This task is only required for a *clean* WEXT interface. Please send any patches to: Greg Kroa

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-27 Thread Wolfram Sang
Hi Tobin, > over this last month :). This is the reason for this email. Can I > please take you up on the offer of the SDW-823 card, if you can find > it? Sure, I have it here. Just mail me (privately) the address to send it to and I'll ship right away. > Secondly, I think I should spend some ti

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-26 Thread Tobin C. Harding
On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote: > Hi, > > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > > a SDW-823 and should use the ks7010 driver. > > Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for > which no driver is known:

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-04 Thread Tobin C. Harding
k with the current firmware? I do not have my hopes up > > about getting any chip information out of Renesas, all I think we have > > to go in is the current WEXT driver. > > Indeed. That is my gut feeling as well and if that is truly the case > your best option would be a cfg8

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-04 Thread Arend Van Spriel
On 3-4-2017 23:39, Tobin C. Harding wrote: > On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: >> seems we are missing out again? > > Sorry, I don't understand what this comment means? My bad. I had to reset my email account in thunderbird and now it needs to learn anew what is

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Tobin C. Harding
On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: > seems we are missing out again? Sorry, I don't understand what this comment means? > On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > > "Tobin C. Harding" writes: > > > >> Except one: do you know off the top of your head of a

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Greg Kroah-Hartman
really like to > > >> > hear them. I am open to all suggestions (even down to trivial coding > > >> > style issues). > > >> > > >> I'll just repeat that the key move to get this driver out of staging is > > >> to get away from the

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Arend Van Spriel
seems we are missing out again? On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > "Tobin C. Harding" writes: > >> Except one: do you know off the top of your head of a canonical >> implementation of a softmac wi-fi driver. > > I'll suggest taking a look at the ath9k driver :) Looking at ks701

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Toke Høiland-Jørgensen
"Tobin C. Harding" writes: > Except one: do you know off the top of your head of a canonical > implementation of a softmac wi-fi driver. I'll suggest taking a look at the ath9k driver :) -Toke ___ devel mailing list de...@linuxdriverproject.org http:/

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Kalle Valo
"Tobin C. Harding" writes: >> >> But if you want a clean WEXT driver first, this is a step in the right >> >> direction. >> > >> > Let's go for a CFG80211 driver and get out of staging :) So next step >> > is I guess study the ath6kl driver, learn how CFG80211 is done and >> > implement that inte

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Tobin C. Harding
; >> I'll just repeat that the key move to get this driver out of staging is > >> to get away from the WEXT interface to CFG80211. Otherwise no chance > >> that wireless maintainers will even look at it. This is a huge change > >> but once it is done, features like

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-02 Thread Kalle Valo
> that wireless maintainers will even look at it. This is a huge change >> but once it is done, features like Michael MIC come with it for free >> (from what I recall, I am not a wireless expert myself). > > That would explain why I could not find more than the Orinoco driv

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-01 Thread Tobin C. Harding
On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote: > Hi, > > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > > a SDW-823 and should use the ks7010 driver. > > Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for > which no driver is known:

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Wolfram Sang
Hi, > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > a SDW-823 and should use the ks7010 driver. Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for which no driver is known: https://wikidevi.com/wiki/Spectec_SDW-821_%28MediaTek%29 For SDW-821 (SD s

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Tobin C. Harding
. > > I'll just repeat that the key move to get this driver out of staging is > to get away from the WEXT interface to CFG80211. Otherwise no chance > that wireless maintainers will even look at it. This is a huge change > but once it is done, features like Michael MIC come wit

Re: [PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

2017-03-31 Thread Tobin C. Harding
On Thu, Mar 30, 2017 at 10:16:05PM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 15:47 +1100, Tobin C. Harding wrote: > > ks7010 currently uses a custom implementation of the Michael MIC > > algorithm. The kernel has an implementation of this algorithm > > already, we s

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Wolfram Sang
of staging is to get away from the WEXT interface to CFG80211. Otherwise no chance that wireless maintainers will even look at it. This is a huge change but once it is done, features like Michael MIC come with it for free (from what I recall, I am not a wireless expert myself). Without the CF

Re: [PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

2017-03-30 Thread Joe Perches
On Fri, 2017-03-31 at 15:47 +1100, Tobin C. Harding wrote: > ks7010 currently uses a custom implementation of the Michael MIC > algorithm. The kernel has an implementation of this algorithm > already, we should use it. ok, trivia: Do please run your patch through checkpatch and fix a

[PATCH RFC] remove custom Michael MIC implementation

2017-03-30 Thread Tobin C. Harding
This RFC can be applied on op on Linus' tree 89970a0 Configuration options needed to build are CONFIG_STAGING=y CONFIG_KS7010=m The ks7010 driver currently uses a custom implementation of the Michael MIC algorithm. The kernel has an implementation of this algorithm already. This patch

[PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

2017-03-30 Thread Tobin C. Harding
ks7010 currently uses a custom implementation of the Michael MIC algorithm. The kernel has an implementation of this algorithm already, we should use it. Remove the custom implementation. Implement helper functions that call the in-tree implementation through the crypto API. Update the makefile

Re: Michael MIC

2017-03-16 Thread Wolfram Sang
Hi, > Is there some technical reason why module ks7010 includes a > implementation of Michael MIC instead of using the implementation in > crypto/? > > Or is this covered by the statement from the TODO > > - check what other upstream wireless mechanisms can be used inst

Michael MIC

2017-03-15 Thread Tobin C. Harding
Hi Wolfram, Is there some technical reason why module ks7010 includes a implementation of Michael MIC instead of using the implementation in crypto/? Or is this covered by the statement from the TODO - check what other upstream wireless mechanisms can be used instead of the custom ones here

[PATCH v2] staging: ks7010: fix spelling of Michael MIC

2017-03-13 Thread Tobin C. Harding
Driver mixes spelling michael and michel in symbol names and comments. Michael here references the IEEE 802.11i Message Integrity Code. It is incorrect to spell it michel and confusing having two spellings for the same thing. Change michel -> micheal in both symbol names and comments. Signed-off-

Re: [PATCH] staging: ks7010: fix spelling of Michael MIC

2017-03-13 Thread Greg Kroah-Hartman
On Mon, Mar 13, 2017 at 08:39:29PM +1100, Tobin C. Harding wrote: > Driver mixes spelling michael and michel in symbol names and > comments. Michael here references the IEEE 802.11i Message Integrity > Code. It is incorrect to spell it michel and confusing having two > spellings for the same thing.

[PATCH] staging: ks7010: fix spelling of Michael MIC

2017-03-13 Thread Tobin C. Harding
Driver mixes spelling michael and michel in symbol names and comments. Michael here references the IEEE 802.11i Message Integrity Code. It is incorrect to spell it michel and confusing having two spellings for the same thing. Change michel -> micheal in both symbol names and comments. Signed-off-

[PATCH v2 08/12] staging: ks7010: fix spelling of Michael MIC

2017-03-08 Thread Tobin C. Harding
Various symbols are named 'michel*'. The keyed hash function name is spelled 'Michael'. Rename symbols michel -> michael. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 16 drivers/staging/ks7010/michael_mic.c | 8 drivers/staging/ks7010/mi

Re: [PATCH 08/12] staging: ks7010: fix spelling of Michael MIC

2017-03-08 Thread Dan Carpenter
On Wed, Mar 08, 2017 at 07:44:41PM +1100, Tobin C. Harding wrote: > On Wed, Mar 08, 2017 at 08:54:39AM +0300, Dan Carpenter wrote: > > On Wed, Mar 08, 2017 at 02:36:53PM +1100, Tobin C. Harding wrote: > > > Various symbols are named 'michel*'. The keyed hash function name is > > > spelled 'Michael'

Re: [PATCH 08/12] staging: ks7010: fix spelling of Michael MIC

2017-03-08 Thread Tobin C. Harding
On Wed, Mar 08, 2017 at 08:54:39AM +0300, Dan Carpenter wrote: > On Wed, Mar 08, 2017 at 02:36:53PM +1100, Tobin C. Harding wrote: > > Various symbols are named 'michel*'. The keyed hash function name is > > spelled 'Michael'. > > > > Rename symbols michel -> michael. > > > > Signed-off-by: Tobin

Re: [PATCH 08/12] staging: ks7010: fix spelling of Michael MIC

2017-03-07 Thread Dan Carpenter
On Wed, Mar 08, 2017 at 02:36:53PM +1100, Tobin C. Harding wrote: > Various symbols are named 'michel*'. The keyed hash function name is > spelled 'Michael'. > > Rename symbols michel -> michael. > > Signed-off-by: Tobin C. Harding > --- > drivers/staging/ks7010/ks_hostif.c | 16 -

[PATCH 08/12] staging: ks7010: fix spelling of Michael MIC

2017-03-07 Thread Tobin C. Harding
Various symbols are named 'michel*'. The keyed hash function name is spelled 'Michael'. Rename symbols michel -> michael. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 16 drivers/staging/ks7010/michael_mic.c | 8 drivers/staging/ks7010/mi