Hi
Thanks for your replies, I've included the changes you suggested in my patch.
Although I guess functionality r8712_set_key () is already done then.
I have also received several complaints already on the patch is not
broken down by the type of errors they contain, and that this is
clearly desc
On Sat, 3 May 2014 23:06:50 +0300, Dan Carpenter
wrote:
> Many of my other comments apply.
>
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 23d539d..1d4475d 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux
Many of my other comments apply.
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 23d539d..1d4475d 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -170,7 +
On Sat, May 03, 2014 at 06:12:11PM +0200, Rickard Strandqvist wrote:
> Hi
>
> The static code analysis program called cppcheck.
> http://cppcheck.sourceforge.net/
>
> I found code that I think are bugs, or at least inappropriate or
> unnecessary code, in the files:
> drivers/staging/tidspbridge/p
This patch wasn't sent in the correct way. The subject should be:
[PATCH] staging: tidspbridge: silence some uninitialized variable warnings
On Sat, May 03, 2014 at 06:12:11PM +0200, Rickard Strandqvist wrote:
> Hi
>
> The static code analysis program called cppcheck.
> http://cppcheck.sourcefo
On Sat, May 03, 2014 at 06:33:11PM +0200, Rickard Strandqvist wrote:
> Hi
>
> The static code analysis program called cppcheck.
> http://cppcheck.sourceforge.net/
>
> I found code that I think are bugs, or at least inappropriate or
> unnecessary code, in the files:
> drivers/staging/rtl8712/rtl87
Hi
The static code analysis program called cppcheck.
http://cppcheck.sourceforge.net/
I found code that I think are bugs, or at least inappropriate or
unnecessary code, in the files:
drivers/staging/tidspbridge/pmgr/dspapi.c
drivers/staging/tidspbridge/rmgr/node.c
I have created a patch, and in
Hi
The static code analysis program called cppcheck.
http://cppcheck.sourceforge.net/
I found code that I think are bugs, or at least inappropriate or
unnecessary code, in the files:
drivers/staging/rtl8712/rtl871x_ioctl_linux.c
drivers/staging/rtl8712/rtl871x_mlme.c
drivers/staging/rtl8712/usb_i
