ic_cleanup(), which ensures that the synic is always
shutdown.
Signed-off-by: Michael Kelley
Reviewed-by: Vitaly Kuznetsov
Reviewed-by: Dexuan Cui
Signed-off-by: Sasha Levin
---
drivers/hv/vmbus_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/
Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on
ARM64, causing the Hyper-V specific code to be built.
Signed-off-by: Michael Kelley
---
drivers/hv/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
index 79e5356
ff-by: Michael Kelley
---
arch/x86/include/asm/mshyperv.h | 4 ++++
drivers/hv/hv.c | 3 +++
2 files changed, 7 insertions(+)
diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index f4138ae..583e1ce 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arc
ff-by: Michael Kelley
---
arch/x86/include/asm/mshyperv.h | 4 ++++
drivers/hv/hv.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index f4138ae..583e1ce 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arc
Update drivers/hv/Kconfig so CONFIG_HYPERV and CONFIG_HYPERV_TSCPAGE
can be selected on ARM64, causing the Hyper-V specific code to be built.
Signed-off-by: Michael Kelley
---
drivers/hv/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/Kconfig b
VM can panic due to memory corruption (the
hypervisor writes data to the wrong location).
Fixes: 6ba34171bcbd ("Drivers: hv: vmbus: Remove use of slow_virt_to_phys()")
Cc: sta...@vger.kernel.org
Cc: Michael Kelley
Reported-and-tested-by: Juliana Rodrigueiro
Signed-off-by: Dexuan Cui
R
> hypervisor writes data to the wrong location).
>
> Fixes: 6ba34171bcbd ("Drivers: hv: vmbus: Remove use of slow_virt_to_phys()")
> Cc: sta...@vger.kernel.org
> Cc: Michael Kelley
> Reported-and-tested-by: Juliana Rodrigueiro
>
> Signed-off
ivers: hv: vmbus: Remove use of slow_virt_to_phys()")
Cc: sta...@vger.kernel.org
Cc: Michael Kelley
Reported-and-tested-by: Juliana Rodrigueiro
Signed-off-by: Dexuan Cui
---
drivers/hv/channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/channel.c b/
From: Kimberly Brown Sent: Monday, February 18, 2019
9:38 PM
>
> There are two methods for signaling the host: the monitor page mechanism
> and hypercalls. The monitor page mechanism is used by performance
> critical channels (storage, networking, etc.) because it provides
> improved throughput
ruct definition indicates
> that the 1st page is for parent->child notifications. In addition, the
> server_monitor_latency_show() and server_monitor_conn_id_show()
> functions use monitor_pages index '0'.
>
> Signed-off-by: Kimberly Brown
> Acked-by: Stephen Hemming
tions. In addition, the
server_monitor_latency_show() and server_monitor_conn_id_show()
functions use monitor_pages index '0'.
Signed-off-by: Kimberly Brown
Acked-by: Stephen Hemminger
---
drivers/hv/vmbus_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/vmb
or_allocated" is
set before accessing the monitor id or the monitor page data. If
"channel->offermsg.monitor_allocated" is not set, return -EINVAL.
Signed-off-by: Kimberly Brown
---
Documentation/ABI/stable/sysfs-bus-vmbus | 15 --
drivers/hv/vmbus_drv.c
by S. Hemminger.
- Updated the sysfs documentation to describe the new return value.
Kimberly Brown (2):
Drivers: hv: vmbus: Change server monitor_pages index to 0
Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set
Documentation/ABI/stable/sysfs-bus-vmbus | 15 +
On Thu, Feb 14, 2019 at 08:54:31PM -0500, Sasha Levin wrote:
> On Sat, Feb 02, 2019 at 03:07:35PM -0500, Kimberly Brown wrote:
> > On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote:
> > > > From: Kimberly Brown
> > > > Sent: Thursday, January 31, 2019 9:47 AM
> > > > ...
> > > > 2) Preven
On Mon, Feb 04, 2019 at 04:25:34PM +, Michael Kelley wrote:
From: Kimberly Brown Sent: Sunday, February 3, 2019
11:13 PM
Counter values for per-channel interrupts and ring buffer full
conditions are useful for investigating performance.
Expose counters in sysfs for 2 types of guest to ho
On Sat, Feb 02, 2019 at 03:07:35PM -0500, Kimberly Brown wrote:
On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote:
> From: Kimberly Brown
> Sent: Thursday, January 31, 2019 9:47 AM
> ...
> 2) Prevent a deadlock that can occur between the proposed mutex_lock()
> call in the vmbus_chan_a
On Thu, 14 Feb 2019 01:11:03 -0500
Kimberly Brown wrote:
> On Mon, Feb 11, 2019 at 10:02:47AM -0800, Stephen Hemminger wrote:
> > On Mon, 11 Feb 2019 02:01:18 -0500
> > Kimberly Brown wrote:
> >
> > > On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote:
> > > > On Fri, 8 Feb 2
On Mon, Feb 11, 2019 at 10:02:47AM -0800, Stephen Hemminger wrote:
> On Mon, 11 Feb 2019 02:01:18 -0500
> Kimberly Brown wrote:
>
> > On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote:
> > > On Fri, 8 Feb 2019 05:01:12 -0500
> > > Kimberly Brown wrote:
> > >
> > > You are right,
On Mon, 11 Feb 2019 02:01:18 -0500
Kimberly Brown wrote:
> On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote:
> > On Fri, 8 Feb 2019 05:01:12 -0500
> > Kimberly Brown wrote:
> >
> > You are right, the current behavior is broken.
> > It would be good to add a description of under
On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote:
> On Fri, 8 Feb 2019 05:01:12 -0500
> Kimberly Brown wrote:
>
> You are right, the current behavior is broken.
> It would be good to add a description of under what conditions
> monitor is not used. Is this some part of a project
On Fri, 8 Feb 2019 05:01:12 -0500
Kimberly Brown wrote:
You are right, the current behavior is broken.
It would be good to add a description of under what conditions
monitor is not used. Is this some part of a project emulating
Hyper-V?
> +
> + if (!hv_dev->channel->offermsg.monitor_allocat
tion indicates
> that the 1st page is for parent->child notifications. In addition, the
> server_monitor_latency_show() and server_monitor_conn_id_show()
> functions use monitor_pages index '0'.
>
> Signed-off-by: Kimberly Brown
> ---
> drivers/hv/vmbus_drv.c |
ocated to a channel. In the affected
"_show" functions, verify that "channel->offermsg.monitor_allocated" is
set before accessing the monitor id or the monitor_page data. If
"channel->offermsg.monitor_allocated" is not set, display nothing.
Signed-off-by: Kimber
tions. In addition, the
server_monitor_latency_show() and server_monitor_conn_id_show()
functions use monitor_pages index '0'.
Signed-off-by: Kimberly Brown
---
drivers/hv/vmbus_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/
a channel, display nothing in
the channel's monitor id and monitor page data sysfs files. The data
that is currently shown in sysfs is incorrect.
Kimberly Brown (2):
Drivers: hv: vmbus: Change server monitor_pages index to 0
Drivers: hv: vmbus: Display nothing in sysfs if monitor_alloca
From: Kimberly Brown Sent: Sunday, February 3, 2019
11:13 PM
>
> Counter values for per-channel interrupts and ring buffer full
> conditions are useful for investigating performance.
>
> Expose counters in sysfs for 2 types of guest to host interrupts:
> 1) Interrupts caused by the channel's ou
e channel's outbound ring buffer
Documentation/ABI/stable/sysfs-bus-vmbus | 33 +
drivers/hv/ring_buffer.c | 14 +++-
drivers/hv/vmbus_drv.c | 36 +++
include/linux/hyperv.h | 46 ++
On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote:
> > From: Kimberly Brown
> > Sent: Thursday, January 31, 2019 9:47 AM
> > ...
> > 2) Prevent a deadlock that can occur between the proposed mutex_lock()
> > call in the vmbus_chan_attr_show() function and the sysfs/kernfs functions.
> Hi
> From: Kimberly Brown
> Sent: Thursday, January 31, 2019 9:47 AM
> ...
> 2) Prevent a deadlock that can occur between the proposed mutex_lock()
> call in the vmbus_chan_attr_show() function and the sysfs/kernfs functions.
Hi Kim,
Can you please share more details about the deadlock?
It's unclear
On Thu, Jan 31, 2019 at 12:47:07PM -0500, Kimberly Brown wrote:
On Thu, Jan 31, 2019 at 04:45:35PM +, Michael Kelley wrote:
From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM
>
> I've queued this one for hyper-fixes, thanks all!
>
Actually, please hold off on queuing this one. In
On Thu, Jan 31, 2019 at 04:45:35PM +, Michael Kelley wrote:
> From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM
> >
> > I've queued this one for hyper-fixes, thanks all!
> >
>
> Actually, please hold off on queuing this one. In a conversation I had
> yesterday with Kim, they had
From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM
>
> I've queued this one for hyper-fixes, thanks all!
>
Actually, please hold off on queuing this one. In a conversation I had
yesterday with Kim, they had identified a deadlock. Kim was going to be
looking at some revisions to avoi
On Tue, Jan 29, 2019 at 07:20:28PM +, Dexuan Cui wrote:
From: Kimberly Brown
> ...
> But as you pointed, at least for sub-channels, channel->ringbuffer_page
> can indeed disappear in vmbus_close() -> ... -> vmbus_free_ring(), and
> the "attribute->show()" could crash when the race happens.
>
> From: Kimberly Brown
> > ...
> > But as you pointed, at least for sub-channels, channel->ringbuffer_page
> > can indeed disappear in vmbus_close() -> ... -> vmbus_free_ring(), and
> > the "attribute->show()" could crash when the race happens.
> > Adding channel_mutex here seems to be able to fi
On Tue, Jan 22, 2019 at 06:40:30PM +, Dexuan Cui wrote:
> > From: Kimberly Brown
> > Sent: Monday, January 21, 2019 10:43 PM
> > > > @@ -1421,7 +1422,10 @@ static ssize_t vmbus_chan_attr_show(struct
> > > > kobject *kobj,
> > > > if (chan->state != CHANNEL_OPENED_STATE)
> > > >
> From: Kimberly Brown
> Sent: Monday, January 21, 2019 10:43 PM
> > > @@ -1421,7 +1422,10 @@ static ssize_t vmbus_chan_attr_show(struct
> > > kobject *kobj,
> > > if (chan->state != CHANNEL_OPENED_STATE)
> > > return -EINVAL;
> > >
> > > - return attribute->show(chan, buf);
> > > + mu
On Tue, Jan 22, 2019 at 03:46:48AM +, Dexuan Cui wrote:
> > From: Kimberly Brown
> > Sent: Monday, January 21, 2019 6:08 PM
> > Subject: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show
> > functions
> >
> > The channel level "_show&quo
> From: Kimberly Brown
> Sent: Monday, January 21, 2019 6:08 PM
> Subject: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions
>
> The channel level "_show" functions are vulnerable to race conditions.
> Add a mutex lock and unlock around the call
Brown
---
drivers/hv/vmbus_drv.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 403fee01572c..e8189bc168da 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1414,6 +1414,7 @@ static ssize_t vmbus_c
On Thu, Jan 17, 2019 at 09:11:03AM -0800, Stephen Hemminger wrote:
>
>
> > +static ssize_t channel_intr_in_full_show(const struct vmbus_channel
> > *channel,
> > +char *buf)
> > +{
> > + return sprintf(buf, "%llu\n", channel->intr_in_full);
> > +}
>
>
> int
> +static ssize_t channel_intr_in_full_show(const struct vmbus_channel
> *channel,
> + char *buf)
> +{
> + return sprintf(buf, "%llu\n", channel->intr_in_full);
> +}
intr_in_full is u64, which is not the same as unsigned long long.
to be correct you nee
moved the host to guest interrupt counters proposed in v1 because
>they were not accurate
> - Added full condition counters for the channel's outbound ring buffer
>
> Documentation/ABI/stable/sysfs-bus-vmbus | 33
> drivers/hv/ring_buffer
> From: Kimberly Brown
> Sent: Wednesday, January 16, 2019 8:38 PM
> To: Michael Kelley ; Long Li
> ; Sasha Levin ;
> Dexuan Cui
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; de...@linuxdriverproject.org;
> linux-ker...@vger.kernel.org
> Subject:
++++++
drivers/hv/ring_buffer.c | 14 ++++++++-
drivers/hv/vmbus_drv.c | 32
include/linux/hyperv.h | 38
4 files changed, 116 insertions(+), 1 deletion(-)
diff --git a/Documentation/ABI/stable/sys
> From: Michael Kelley
> Sent: Saturday, January 5, 2019 1:01 PM
> > From: Kimberly Brown Sent: Friday, January 4,
> > 2019 8:35 PM
> >
> > static inline void set_channel_pending_send_size(struct vmbus_channel *c,
> > u32 size)
> > {
> > + if (si
> From: Kimberly Brown
> Sent: Friday, January 4, 2019 8:35 PM
...
> +What:
> /sys/bus/vmbus/devices//channels//intr_in_full
> +Date: January 2019
> +KernelVersion: 4.21
There is no 4.21 version: see https://lkml.org/lkml/2019/1/6/178 :-)
Thanks!
-- Dexuan
__
From: Kimberly Brown Sent: Friday, January 4, 2019 8:35
PM
> static inline void set_channel_pending_send_size(struct vmbus_channel *c,
>u32 size)
> {
> + if (size) {
> + ++c->out_full_total;
> +
> + if (!c->out_full_f
Documentation/ABI/stable/sysfs-bus-vmbus | 33 ++++++++++++
drivers/hv/ring_buffer.c | 14 +++++-
drivers/hv/vmbus_drv.c | 32 +++
include/linux/hyperv.h | 32 +++
4 files changed, 110 i
state or
ring_info->ring_buffer, when using the function in the future.
Having an error check in the function would eliminate the potential risk.
Add a Fixes tag to indicate the patch depdendency.
Fixes: fc96df16a1ce ("Drivers: hv: vmbus: Return -EINVAL for the sys files for
unopened channels&qu
On Mon, 17 Dec 2018 18:44:12 +
Dexuan Cui wrote:
> > From: devel On Behalf Of
> > Dexuan Cui
> > Sent: Monday, December 17, 2018 10:31 AM
> > > From: Stephen Hemminger
> > >
> > > The old code was risky because it would silently return stack garbage.
> > > Having an error check in get_deb
ure.
Having an error check in the function would eliminate the potential risk.
Add a Fixes tag to indicate the patch depdendency.
Fixes: fc96df16a1ce ("Drivers: hv: vmbus: Return -EINVAL for the sys files for
unopened channels")
Cc: sta...@vger.kernel.org
Cc: K. Y. Srinivasan
C
> From: devel On Behalf Of
> Dexuan Cui
> Sent: Monday, December 17, 2018 10:31 AM
> > From: Stephen Hemminger
> >
> > The old code was risky because it would silently return stack garbage.
> > Having an error check in get_debuginfo would eliminate that.
>
> OK, then let me make another patch ba
> From: Stephen Hemminger
> Sent: Monday, December 17, 2018 10:17 AM
> To: Dexuan Cui
>
> On Mon, 17 Dec 2018 18:00:29 +
> Dexuan Cui wrote:
>
> > > From: Stephen Hemminger
> > > On Thu, 13 Dec 2018 16:35:43 +
> > > Dexuan Cui wrote:
> > >
> > > > Before 98f4c651762c, we returned zer
On Mon, 17 Dec 2018 18:00:29 +
Dexuan Cui wrote:
> > From: Stephen Hemminger
> > On Thu, 13 Dec 2018 16:35:43 +
> > Dexuan Cui wrote:
> >
> > > Before 98f4c651762c, we returned zeros for unopened channels.
> > > With 98f4c651762c, we started to return random on-stack values.
> > >
>
> From: Stephen Hemminger
> On Thu, 13 Dec 2018 16:35:43 +
> Dexuan Cui wrote:
>
> > Before 98f4c651762c, we returned zeros for unopened channels.
> > With 98f4c651762c, we started to return random on-stack values.
> >
> > We'd better return -EINVAL instead.
>
> The concept looks fine, but
: vmbus: check for ring in debug info
---
drivers/hv/ring_buffer.c | 31 +-
drivers/hv/vmbus_drv.c | 71 ++--
include/linux/hyperv.h | 5 +--
3 files changed, 79 insertions(+), 28 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/driver
On Thu, Dec 13, 2018 at 04:35:43PM +, Dexuan Cui wrote:
Before 98f4c651762c, we returned zeros for unopened channels.
With 98f4c651762c, we started to return random on-stack values.
We'd better return -EINVAL instead.
Fixes: 98f4c651762c ("hv: move ringbuffer bus attributes to dev_groups")
Srinivasan
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Signed-off-by: Dexuan Cui
---
drivers/hv/vmbus_drv.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 283d184..d0ff656 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers
On Mon, Dec 03, 2018 at 02:50:19PM +0300, Dan Carpenter wrote:
> The list is still rejecting @microsoft.com patches... :(
>
> I mentioned this last time when you guys were complaining that no one
> reads your patches and someone sent me a link to marc.info. I want to
> help but obviously no one
The list is still rejecting @microsoft.com patches... :(
I mentioned this last time when you guys were complaining that no one
reads your patches and someone sent me a link to marc.info. I want to
help but obviously no one has time to look at patches on marc.info...
regards,
dan carpenter
From: Will Deacon Sent: Tuesday, November 27, 2018 2:19
AM
> > > The general approach is for patches 1 and 2 of the series to provide
> > > all the new code under arch/arm64 to enable Hyper-V. But the code
> > > won't get called (or even built) with just these two patches because
> > > CONFIG_
ost), but there was a conflict issue.
We have done a full testing with the patch.
We hope the important patch can be in the final v4.20. Thanks!
drivers/hv/channel_mgmt.c | 189 ++++++
drivers/hv/connection.c | 24 +-
drivers/hv/hyperv_vmbus.h
w...@redhat.com; Michael
> Kelley
> Subject: Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of
> channels to two workqueues
>
> On Sun, Dec 02, 2018 at 08:47:03AM +, Dexuan Cui wrote:
> > Hi Greg,
> > Please use the attached patch: I rebased the patch to
On Sun, Dec 02, 2018 at 08:47:03AM +, Dexuan Cui wrote:
> Hi Greg,
> Please use the attached patch: I rebased the patch to today's char-misc's
> char-misc-linus branch. It can also cleanly apply to Linus's master branch
> today.
I can't use an attached patch, you know better. Please fix up an
.de; jasow...@redhat.com; Michael
> Kelley
> Subject: Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of
> channels to two workqueues
>
> On Fri, Nov 30, 2018 at 06:09:54PM +, Dexuan Cui wrote:
> > > From: KY Srinivasan
> > > Sent: Friday, Novembe
c: KY Srinivasan ; Haiyang Zhang
> > > ; Stephen Hemminger
> > > ; linux-ker...@vger.kernel.org;
> > > de...@linuxdriverproject.org; a...@canonical.com; vkuznets
> > > ; o...@aepfle.de; jasow...@redhat.com; Michael
> > > Kelley
> > > Subj
gt; ; linux-ker...@vger.kernel.org;
> > de...@linuxdriverproject.org; a...@canonical.com; vkuznets
> > ; o...@aepfle.de; jasow...@redhat.com; Michael
> > Kelley
> > Subject: RE: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of
> > channels to two workqueues
> >
> > &
ical.com; vkuznets
> ; o...@aepfle.de; jasow...@redhat.com; Michael
> Kelley
> Subject: RE: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of
> channels to two workqueues
>
> > From: gre...@linuxfoundation.org
> > Sent: Wednesday, November 28, 2018 11:45 PM
> >
f-by (which is kept in this repost), but there was a conflict
> > issue.
> >
> > Note: the patch can't be cleanly applied to char-misc's char-misc-linus
> > branch
> --
> > to do that, we need to cherry-pick the supporting patch first:
> > 4d3c5c69191
hange in this repost. I just rebased this patch to today's
> char-misc's char-misc-next branch. Previously KY posted the patch with his
> Signed-off-by (which is kept in this repost), but there was a conflict issue.
>
> Note: the patch can't be cleanly applied to char-misc&#x
ed to char-misc's char-misc-linus branch
--
to do that, we need to cherry-pick the supporting patch first:
4d3c5c69191f ("Drivers: hv: vmbus: Remove the useless API
vmbus_get_outgoing_channel()")
drivers/hv/channel_mgmt.c | 188 +++++++---
driv
On Tue, Nov 27, 2018 at 07:20:56AM +0100, Greg KH wrote:
> On Mon, Nov 26, 2018 at 08:56:50PM +, Michael Kelley wrote:
> > From: Greg KH Monday, November 26, 2018 11:57
> > AM
> >
> > > > > You created "null" hooks that do nothing, for no one in this patch
> > > > > series, why?
> > > > >
>
On Mon, Nov 26, 2018 at 08:56:50PM +, Michael Kelley wrote:
> From: Greg KH Monday, November 26, 2018 11:57 AM
>
> > > > You created "null" hooks that do nothing, for no one in this patch
> > > > series, why?
> > > >
> > >
> > > hv_enable_vmbus_irq() and hv_disable_vmbus_irq() have non-null
gt; ; vkuznets ; Haiyang
> Zhang ; sta...@vger.kernel.org
> Subject: Re: [PATCH 2/2] Drivers: hv: vmbus: offload the handling of channels
> to two workqueues
>
> On Mon, Nov 26, 2018 at 02:29:57AM +, k...@linuxonhyperv.com wrote:
> > From: Dexuan Cui
>
From: Greg KH Monday, November 26, 2018 11:57 AM
> > > You created "null" hooks that do nothing, for no one in this patch
> > > series, why?
> > >
> >
> > hv_enable_vmbus_irq() and hv_disable_vmbus_irq() have non-null
> > implementations in the ARM64 code in patch 2 of this series. The
> > impl
> From: devel On Behalf Of
> Greg KH
> Sent: Monday, November 26, 2018 11:35 AM
> As Sasha pointed out, this patch does not even apply :(
Sorry, I'll rebase to char-misc's char-misc-testing branch, which has had one
of the patches, i.e.
4d3c5c69191f ("Drivers: hv: vm
static inline void hv_enable_vmbus_irq(void) {}
> > +static inline void hv_disable_vmbus_irq(void) {}
> > +
> > void hv_setup_kexec_handler(void (*handler)(void));
> > void hv_remove_kexec_handler(void);
> > void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));
>
oid (*handler)(void));
> > > void hv_remove_kexec_handler(void);
> > > void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));
> > > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > > index 166c2501de17..d0bb09a4bd73 100644
> > > --- a/d
8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Cc: sta...@vger.kernel.org
> Cc: Stephen Hemminger
> Cc: K. Y. Srinivasan
> Cc: Haiyang Zhang
> Signed-off-by: Dexuan Cui
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/hv/channel_mgmt.c | 188 +
yper-V on ARM64. The
> x86/x64 implementation is null because VMbus interrupts on x86/x64
> don't use an IRQ.
>
> Signed-off-by: Michael Kelley
> Signed-off-by: K. Y. Srinivasan
> ---
> arch/x86/include/asm/mshyperv.h | 4
> drivers/hv/hv.c | 2 ++
&
On Mon, Nov 26, 2018 at 02:29:57AM +, k...@linuxonhyperv.com wrote:
From: Dexuan Cui
vmbus_process_offer() mustn't call channel->sc_creation_callback()
directly for sub-channels, because sc_creation_callback() ->
vmbus_open() may never get the host's response to the
OPEN_CHANNEL message (th
. Y. Srinivasan
Cc: Haiyang Zhang
Cc: sta...@vger.kernel.org
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index f96a77b18bb9..ce0ba2062723 100644
--- a/d
he patch should be applied to all the existing kernels.
Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Haiyang Zhang
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel
From: "K. Y. Srinivasan"
Miscellaneous fixes.
Dexuan Cui (2):
Drivers: hv: vmbus: check the creation_status in
vmbus_establish_gpadl()
Drivers: hv: vmbus: offload the handling of channels to two workqueues
drivers/hv/channel.c | 8 ++
drivers/hv/channel_mg
otentially unsafe, because it reads primary->num_sc without
any lock held. This can be risky considering the RESCIND-OFFER message.
Let's remove the API.
Cc: Long Li
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: Haiyang Zhang
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasa
From: Michael Kelley
Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on ARM64,
causing the Hyper-V specific code to be built.
Signed-off-by: Michael Kelley
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
se an IRQ.
Signed-off-by: Michael Kelley
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h | 4 ++++
drivers/hv/hv.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index 0d6271c
driverproject.org; o...@aepfle.de; a...@canonical.com;
> > jasow...@redhat.com; Stephen Hemminger ;
> > vkuznets ; Sasha Levin
> > ; Haiyang Zhang ;
> > sta...@vger.kernel.org
> > Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression
> > caused
> > b
;
> vkuznets ; Sasha Levin
> ; Haiyang Zhang ;
> sta...@vger.kernel.org
> Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused
> by incorrect clean-up
>
> On Thu, Nov 01, 2018 at 07:22:28PM +, Dexuan Cui wrote:
> > > From: gre...@linuxfounda
Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on ARM64,
causing the Hyper-V specific code to be built.
Signed-off-by: Michael Kelley
---
drivers/hv/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
index 97954f5
ff-by: Michael Kelley
---
arch/x86/include/asm/mshyperv.h | 4 ++++
drivers/hv/hv.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index 0d6271c..8d97bd3 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arc
> jasow...@redhat.com; Stephen Hemminger ;
> vkuznets ; Sasha Levin
> ; Haiyang Zhang
> ; sta...@vger.kernel.org
> Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused
> by incorrect clean-up
>
> On Wed, Oct 31, 2018 at 11:23:54PM +, Dexuan Cui
so the default key_size
> > > > > of
> > > > > 0 is passed to the kvp daemon, and the pool files
> > > > > /var/lib/hyperv/.kvp_pool_* can't be updated.
> > > > >
> > > > > This patch effectively rolls back the prev
;
> Michael Kelley ; vkuznets
> Cc: Dexuan Cui ; KY Srinivasan ;
> Haiyang Zhang ; sta...@vger.kernel.org
> Subject: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by
> incorrect clean-up
>
> From: Dexuan Cui
>
> In kvp_send_key(), we
't be updated.
> > > >
> > > > This patch effectively rolls back the previous fc62c3b1977d, and
> > > > correctly fixes the "this statement may fall through" warnings.
> > > >
> > > > This patch is tested on WS 2012 R
on, and the pool files
> > > /var/lib/hyperv/.kvp_pool_* can't be updated.
> > >
> > > This patch effectively rolls back the previous fc62c3b1977d, and
> > > correctly fixes the "this statement may fall through" warnings.
> > >
&
ack the previous fc62c3b1977d, and
> > correctly fixes the "this statement may fall through" warnings.
> >
> > This patch is tested on WS 2012 R2 and 2016.
> >
> > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall
f
> 0 is passed to the kvp daemon, and the pool files
> /var/lib/hyperv/.kvp_pool_* can't be updated.
>
> This patch effectively rolls back the previous fc62c3b1977d, and
> correctly fixes the "this statement may fall through" warnings.
>
> This patch is tested on
global state in struct hv_context.
> Get rid of this state in struct hv_context.
>
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/hv/hv.c | 10 +++---
> drivers/hv/hyperv_vmbus.h | 2 --
> 2 files changed, 3 insertions(+), 9 deletio
Hi Dan,
On Sat, Oct 20, 2018 at 9:22 PM Dan Carpenter wrote:
>
> On Sat, Oct 20, 2018 at 04:42:07PM +0200, Miguel Ojeda wrote:
> > Using an attribute is indeed better whenever possible. In C++17 it is
> > an standard attribute and there have been proposals to include some of
> > them for C as wel
1 - 100 of 1891 matches
Mail list logo
