Re: Concerning [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

2017-07-29 Thread Marcus Wolf
Hi Dan, the "big" patch, I was telling about yesterday will touch exactly that file. So if you are planning deep changes, we will most probably run into conflicts. If I'll find some time (maybe tomorrow), I'll try to send that long patch, so you can see. Already nervous about next failing patch

Re: Concerning [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

2017-07-29 Thread Dan Carpenter
On Sat, Jul 29, 2017 at 11:16:11AM +0200, Marcus Wolf wrote: > Hi Greg, > > there is another patch from me (see subject). I sent it 19/07/2017. > > Most probably, there is also something wrong with the patch, but maybe you can > get it to work. > > The patch would be important. It doesn't fix a

Concerning [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

2017-07-29 Thread Marcus Wolf
Hi Greg, there is another patch from me (see subject). I sent it 19/07/2017. Most probably, there is also something wrong with the patch, but maybe you can get it to work. The patch would be important. It doesn't fix any warnings or errors of static code analysis, but it fixes true implementati