Re: Comedi use of standard types

2017-02-22 Thread Dan Carpenter
On Thu, Feb 23, 2017 at 07:48:59AM +1100, Tobin C. Harding wrote: > On Wed, Feb 22, 2017 at 04:51:05PM +0300, Dan Carpenter wrote: > > On Wed, Feb 22, 2017 at 11:46:07AM +, Ian Abbott wrote: > > > On 21/02/17 21:27, Tobin C. Harding wrote: > > > >Comedi drivers make heavy use of standard types

Re: Comedi use of standard types

2017-02-22 Thread Tobin C. Harding
On Wed, Feb 22, 2017 at 04:51:05PM +0300, Dan Carpenter wrote: > On Wed, Feb 22, 2017 at 11:46:07AM +, Ian Abbott wrote: > > On 21/02/17 21:27, Tobin C. Harding wrote: > > >Comedi drivers make heavy use of standard types i.e unsigned > > >short. According to Linux Device Drivers standard C data

Re: Comedi use of standard types

2017-02-22 Thread Dan Carpenter
On Wed, Feb 22, 2017 at 04:51:05PM +0300, Dan Carpenter wrote: > > >Is the choice (size) of type in a struct (eg struct ni_private, > > >comedi/drivers/ni_stc.h) a kernel design issue or is it a hardware > > >issue and should I be reading the manual to find it. > > > > It's mostly a design issue.

Re: Comedi use of standard types

2017-02-22 Thread Dan Carpenter
On Wed, Feb 22, 2017 at 11:46:07AM +, Ian Abbott wrote: > On 21/02/17 21:27, Tobin C. Harding wrote: > >Comedi drivers make heavy use of standard types i.e unsigned > >short. According to Linux Device Drivers standard C data types are not > >the same size of all architectures. > > > >Should we

Re: Comedi use of standard types

2017-02-22 Thread Ian Abbott
On 21/02/17 21:27, Tobin C. Harding wrote: Comedi drivers make heavy use of standard types i.e unsigned short. According to Linux Device Drivers standard C data types are not the same size of all architectures. Should we be converting comedi/drivers to use kernel types u8, u16 etc Linux kernel

Re: Comedi use of standard types

2017-02-21 Thread Tobin C. Harding
On Wed, Feb 22, 2017 at 08:27:37AM +1100, Tobin C. Harding wrote: > Comedi drivers make heavy use of standard types i.e unsigned > short. According to Linux Device Drivers standard C data types are not > the same size of all architectures. > > Should we be converting comedi/drivers to use kernel t

Comedi use of standard types

2017-02-21 Thread Tobin C. Harding
Comedi drivers make heavy use of standard types i.e unsigned short. According to Linux Device Drivers standard C data types are not the same size of all architectures. Should we be converting comedi/drivers to use kernel types u8, u16 etc Follow up question. Some comedi/drivers also use unsigned