Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-12 Thread Alan Cox
On Fri, 12 May 2017 20:35:18 +0100 Okash Khawaja wrote: > On Thu, May 11, 2017 at 02:33:14PM +0100, Alan Cox wrote: > > On Thu, 11 May 2017 09:29:14 +0100 > > Okash Khawaja wrote: > > > > > Hi Alan, > > > > > > On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote: > > > > > + if (!

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-12 Thread Okash Khawaja
On Thu, May 11, 2017 at 02:33:14PM +0100, Alan Cox wrote: > On Thu, 11 May 2017 09:29:14 +0100 > Okash Khawaja wrote: > > > Hi Alan, > > > > On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote: > > > > + if (!(tmp_termios.c_cflag & CRTSCTS)) { > > > > + tmp_termios.c_cfl

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-11 Thread Alan Cox
On Thu, 11 May 2017 09:29:14 +0100 Okash Khawaja wrote: > Hi Alan, > > On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote: > > > + if (!(tmp_termios.c_cflag & CRTSCTS)) { > > > + tmp_termios.c_cflag |= CRTSCTS; > > > + ret = tty_set_termios(tty, &tmp_termios); > > > +

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-11 Thread Okash Khawaja
Hi Alan, On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote: > > + if (!(tmp_termios.c_cflag & CRTSCTS)) { > > + tmp_termios.c_cflag |= CRTSCTS; > > + ret = tty_set_termios(tty, &tmp_termios); > > + if (ret) > > + pr_warn("speakup: Failed to

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-10 Thread Alan Cox
> + if (!(tmp_termios.c_cflag & CRTSCTS)) { > + tmp_termios.c_cflag |= CRTSCTS; > + ret = tty_set_termios(tty, &tmp_termios); > + if (ret) > + pr_warn("speakup: Failed to set hardware flow > control\n"); You should check the tty c_cflag

[patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-09 Thread okash . khawaja
This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when synt