Re: [lustre-devel] [patch] staging: lustre: remove unused variable

2015-11-03 Thread Dilger, Andreas
On 2015/11/03, 15:38, "Simmons, James A." wrote: >>The "->lr_lvb_data" struct member is never used. Delete it. >> >>Signed-off-by: Dan Carpenter >>--- >>I have compile tested this. I looked through the history and it seems >>to never have been used. I wonder if we can remove the locking as we

Re: [patch] staging: lustre: remove unused variable

2015-11-03 Thread Greg Kroah-Hartman
On Tue, Nov 03, 2015 at 10:38:15PM +, Simmons, James A. wrote: > > >The "->lr_lvb_data" struct member is never used. Delete it. > > > >Signed-off-by: Dan Carpenter > >--- > >I have compile tested this. I looked through the history and it seems > >to never have been used. I wonder if we can

RE: [patch] staging: lustre: remove unused variable

2015-11-03 Thread Simmons, James A.
>The "->lr_lvb_data" struct member is never used. Delete it. > >Signed-off-by: Dan Carpenter >--- >I have compile tested this. I looked through the history and it seems >to never have been used. I wonder if we can remove the locking as well. This is used by the quota and ofd layer which are b

[patch] staging: lustre: remove unused variable

2015-11-03 Thread Dan Carpenter
The "->lr_lvb_data" struct member is never used. Delete it. Signed-off-by: Dan Carpenter --- I have compile tested this. I looked through the history and it seems to never have been used. I wonder if we can remove the locking as well. diff --git a/drivers/staging/lustre/lustre/include/lustre_

[PATCH] staging: lustre: remove unused variable warning

2015-05-19 Thread Arnd Bergmann
A recent patch to simplify the lustre large memory allocation causes new warnings as an unintended side-effect: lustre/lov/lov_request.c: In function 'lov_finish_set': lustre/lov/lov_request.c:78:7: warning: unused variable 'len' [-Wunused-variable] int len = set->set_oabufs * sizeof(*set->set

Re: [PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Drokin, Oleg
Hello! On May 11, 2015, at 7:43 AM, Sudip Mukherjee wrote: > On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote: >> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: >>> - if (set->set_pga) { >>> - int len = set->set_oabufs * sizeof(*set->set_pga); >>> + if

Re: [PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Sudip Mukherjee
On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote: > On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: > > - if (set->set_pga) { > > - int len = set->set_oabufs * sizeof(*set->set_pga); > > + if (set->set_pga) > > OBD_FREE_LARGE(set->set_pga, len

Re: [PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Dan Carpenter
On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: > there variables were not used anywhere and was showing as build warning. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/lustre/lustre/lov/lov_request.c | 4 +--- > drivers/staging/lustre/lustre/obdclass/acl.c| 1 -

[PATCH] staging: lustre: remove unused variable

2015-05-11 Thread Sudip Mukherjee
there variables were not used anywhere and was showing as build warning. Signed-off-by: Sudip Mukherjee --- drivers/staging/lustre/lustre/lov/lov_request.c | 4 +--- drivers/staging/lustre/lustre/obdclass/acl.c| 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/stagi