Re: [patch] staging: comedi: pcl812: missing break statement

2013-08-21 Thread Dan Carpenter
On Wed, Aug 21, 2013 at 12:35:22PM +0100, Ian Abbott wrote: > > Acked-by: Ian Abbott > Reviewed-by: Ian Abbott > > (whichever is appropriate) To me Acked-by is more emphatic. Since you're the maintainer it's appropriate. I normally use "Reviewed-by" because I don't have the authority to appr

Re: [patch] staging: comedi: pcl812: missing break statement

2013-08-21 Thread Ian Abbott
On 2013-08-21 11:44, Ian Abbott wrote: On 2013-08-21 09:28, Dan Carpenter wrote: Smatch complains that there is a missing break statement here. Signed-off-by: Dan Carpenter --- This looks correct to me, but please double check. diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/s

Re: [patch] staging: comedi: pcl812: missing break statement

2013-08-21 Thread Ian Abbott
On 2013-08-21 09:28, Dan Carpenter wrote: Smatch complains that there is a missing break statement here. Signed-off-by: Dan Carpenter --- This looks correct to me, but please double check. diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c index 352

[patch] staging: comedi: pcl812: missing break statement

2013-08-21 Thread Dan Carpenter
Smatch complains that there is a missing break statement here. Signed-off-by: Dan Carpenter --- This looks correct to me, but please double check. diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c index 35251e7..03a0989 100644 --- a/drivers/staging/c