On Thu, Sep 05, 2013 at 05:15:02PM -0300, Fabio Estevam wrote:
> Looks good, just one minor suggestion:
>
> On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter
> wrote:
> > +static void lradc_reg_set(struct mxs_lradc *lradc, u32 val, size_t chan)
> > +{
> > + writel(val, lradc->base + chan + STM
On Fri, Sep 06, 2013 at 09:01:01AM +0200, Jürgen Beisert wrote:
>
> Oh, I did the same yesterday in preparation of the v2 of my patch series.
> I will send this new version out today.
>
Ah fine. Then let's drop my version.
regards,
dan carpenter
___
Hi Dan,
On Thursday 05 September 2013 20:16:39 Dan Carpenter wrote:
> I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
> the callers and makes the lines shorter.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> b/drivers/staging/iio/ad
Dear Fabio Estevam,
> On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter
wrote:
> > I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
> > the callers and makes the lines shorter.
>
> Looks good, just one minor suggestion:
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a/
On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter wrote:
> I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
> the callers and makes the lines shorter.
Looks good, just one minor suggestion:
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>
I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
the callers and makes the lines shorter.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/iio/adc/mxs-lradc.c
b/drivers/staging/iio/adc/mxs-lradc.c
index a08c173..da5d04b 100644
--- a/drivers/staging/iio/adc/mxs-lr
