Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Greg Kroah-Hartman
On Mon, Sep 21, 2015 at 01:03:52PM -0400, Doug Ledford wrote: > On 09/21/2015 12:48 PM, Greg Kroah-Hartman wrote: > > > But, that's already not happening, as is obvious by my inbox. > > Yeah, I see that. > > > So, how about you forward on what you have so far to me, and I'll keep > > these. Oth

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Doug Ledford
On 09/21/2015 12:48 PM, Greg Kroah-Hartman wrote: > But, that's already not happening, as is obvious by my inbox. Yeah, I see that. > So, how about you forward on what you have so far to me, and I'll keep > these. Otherwise you will end up with nasty merge issues very quickly > as people will c

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Greg Kroah-Hartman
On Mon, Sep 21, 2015 at 11:42:28AM -0400, Doug Ledford wrote: > On 09/18/2015 11:01 PM, Greg Kroah-Hartman wrote: > > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > >> On 09/16/2015 02:22 AM, Dan Carpenter wrote: > >>> __get_txreq() returns an ERR_PTR() but this checks for NULL so

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-21 Thread Doug Ledford
On 09/18/2015 11:01 PM, Greg Kroah-Hartman wrote: > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: >> On 09/16/2015 02:22 AM, Dan Carpenter wrote: >>> __get_txreq() returns an ERR_PTR() but this checks for NULL so it would >>> oops on failure. >>> >>> Signed-off-by: Dan Carpenter >>

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-20 Thread Greg Kroah-Hartman
On Sat, Sep 19, 2015 at 10:49:52PM +, Weiny, Ira wrote: > > > > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > > > On 09/16/2015 02:22 AM, Dan Carpenter wrote: > > > > __get_txreq() returns an ERR_PTR() but this checks for NULL so it > > > > would oops on failure. > > > > > >

RE: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-19 Thread Weiny, Ira
> > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > > On 09/16/2015 02:22 AM, Dan Carpenter wrote: > > > __get_txreq() returns an ERR_PTR() but this checks for NULL so it > > > would oops on failure. > > > > > > Signed-off-by: Dan Carpenter > > > > Thanks, applied. > > Applied to

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-18 Thread Greg Kroah-Hartman
On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > On 09/16/2015 02:22 AM, Dan Carpenter wrote: > > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would > > oops on failure. > > > > Signed-off-by: Dan Carpenter > > Thanks, applied. Applied to what? Should I just

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-18 Thread Doug Ledford
On 09/16/2015 02:22 AM, Dan Carpenter wrote: > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would > oops on failure. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signatu

[patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-15 Thread Dan Carpenter
__get_txreq() returns an ERR_PTR() but this checks for NULL so it would oops on failure. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rdma/hfi1/verbs.c b/drivers/staging/rdma/hfi1/verbs.c index 53ac214..41bb59e 100644 --- a/drivers/staging/rdma/hfi1/verbs.c +++ b/drivers/staging/rd