Re: [patch] [media] Staging: dt3155v4l: set error code on failure

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 8:55 PM, Dan Carpenter wrote: > > We should be returning -ENOMEM here instead of success. > > Signed-off-by: Dan Carpenter It looks good. video_device_alloc() calls kzalloc(); thus, when video_device_alloc() returns NULL, '-ENOMEM' should be returned. Reviewed-by: Jingo

[patch] [media] Staging: dt3155v4l: set error code on failure

2014-05-09 Thread Dan Carpenter
We should be returning -ENOMEM here instead of success. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/staging/media/dt3155v4l/dt3155v4l.c index afbc2e5..178aa5b 100644 --- a/drivers/staging/media/dt3155v4l/dt3155v4l.c +++ b/drivers/staging/media