Re: [bug report] staging/atomisp: Add support for the Intel IPU v2

2017-03-16 Thread Alan Cox
>    457  if (ret) >    458  return ret; > ^^ > We're returning directly with the lock held.  We should either unlock > before returning or do a goto out but I'm not sure which. unlock and return (although clearly this

[bug report] staging/atomisp: Add support for the Intel IPU v2

2017-03-14 Thread Dan Carpenter
Hello Alan Cox, The patch a49d25364dfb: "staging/atomisp: Add support for the Intel IPU v2" from Feb 17, 2017, leads to the following static checker warning: drivers/staging/media/atomisp/i2c/imx/imx.c:498 imx_set_exposure_gain() warn: inconsistent returns 'mutex:&dev->input_lock'