Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-17 Thread Dan Carpenter
On Tue, Jul 17, 2018 at 12:13:40PM +0300, Dan Carpenter wrote: > > +static ssize_t sysfs_read(struct device *dev, char *buf, > > + unsigned int addr_offset) > > +{ > > + struct axis_fifo *fifo = dev_get_drvdata(dev); > > + unsigned int read_val; > > + unsigned int strlen;

Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-17 Thread Dan Carpenter
This version is much much better. On Sun, Jul 15, 2018 at 12:34:28PM -0400, Jacob Feder wrote: > +static ssize_t sysfs_write(struct device *dev, const char *buf, > +size_t count, unsigned int addr_offset) > +{ > + struct axis_fifo *fifo = dev_get_drvdata(dev); > + u

Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-16 Thread Jacob Feder
On Mon, Jul 16, 2018 at 09:43:47AM +0200, Greg KH wrote: > On Sun, Jul 15, 2018 at 04:38:51PM -0400, Jacob Feder wrote: > > On Sun, Jul 15, 2018 at 09:44:58PM +0200, Greg KH wrote: > > > On Sun, Jul 15, 2018 at 12:34:28PM -0400, Jacob Feder wrote: > > > > Hi, > > > > I have updated this with the re

Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-16 Thread Greg KH
On Sun, Jul 15, 2018 at 04:38:51PM -0400, Jacob Feder wrote: > On Sun, Jul 15, 2018 at 09:44:58PM +0200, Greg KH wrote: > > On Sun, Jul 15, 2018 at 12:34:28PM -0400, Jacob Feder wrote: > > > Hi, > > > I have updated this with the recommended changes. I haven't tried out the > > > UIO though. It wil

Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-15 Thread Jacob Feder
On Sun, Jul 15, 2018 at 09:44:58PM +0200, Greg KH wrote: > On Sun, Jul 15, 2018 at 12:34:28PM -0400, Jacob Feder wrote: > > Hi, > > I have updated this with the recommended changes. I haven't tried out the > > UIO though. It will be a pretty significant undertaking and I don't want > > to spend the

Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-15 Thread Greg KH
On Sun, Jul 15, 2018 at 12:34:28PM -0400, Jacob Feder wrote: > Hi, > I have updated this with the recommended changes. I haven't tried out the > UIO though. It will be a pretty significant undertaking and I don't want > to spend the time on it unless there is a specific reason you think it > will b

[RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-15 Thread Jacob Feder
Hi, I have updated this with the recommended changes. I haven't tried out the UIO though. It will be a pretty significant undertaking and I don't want to spend the time on it unless there is a specific reason you think it will be faster. Thanks all. Cheers, Jacob This IP core has read and write