On Fri, 11 Mar 2016 10:59:02 +0100
Hans Verkuil wrote:
> While userspace may specify FIELD_ANY when setting a format, the
> driver should always map that to a specific field setting and should
> never return FIELD_ANY back to userspace.
>
> In this case, the 'field' field of the v4l2_buffer struc
On 03/11/2016 09:40 AM, Andrey Utkin wrote:
> On Fri, 11 Mar 2016 09:00:18 +0100
> Hans Verkuil wrote:
>> The reason is likely to be the tw5864_queue_setup function which has
>> not been updated to handle CREATE_BUFS support correctly. It should
>> look like this:
>>
>> static int tw5864_queue_set
On Fri, 11 Mar 2016 09:00:18 +0100
Hans Verkuil wrote:
> The reason is likely to be the tw5864_queue_setup function which has
> not been updated to handle CREATE_BUFS support correctly. It should
> look like this:
>
> static int tw5864_queue_setup(struct vb2_queue *q,
>
On 03/09/2016 03:29 PM, Andrey Utkin wrote:
> Hi Hans!
>
> Some improvements took place on the driver, including cleaner
> v4l2-compliance tests passing. But there's a single test failure I
> don't understand.
>
> In the code of v4l2-compliance, it seems like an API
> call CREATE_BUFS is supposed
Hi Hans!
Some improvements took place on the driver, including cleaner
v4l2-compliance tests passing. But there's a single test failure I
don't understand.
In the code of v4l2-compliance, it seems like an API
call CREATE_BUFS is supposed to fail with EINVAL. But in case of my
driver, which simply
On 02/08/2016 11:23 AM, Andrey Utkin wrote:
> On Mon, Feb 8, 2016 at 11:58 AM, Hans Verkuil wrote:
>> Hi Andrey,
>>
>> Hmm, it looks like I forgot to reply. Sorry about that.
>
> Thank you very much anyway.
>
>> I wouldn't change the memcpy: in my experience it is very useful to get a
>> well-fo
On Mon, Feb 8, 2016 at 11:58 AM, Hans Verkuil wrote:
> Hi Andrey,
>
> Hmm, it looks like I forgot to reply. Sorry about that.
Thank you very much anyway.
> I wouldn't change the memcpy: in my experience it is very useful to get a
> well-formed compressed stream out of the hardware. And the overh
Hi Andrey,
Hmm, it looks like I forgot to reply. Sorry about that.
On 01/15/2016 03:13 AM, Andrey Utkin wrote:
> On Mon, Jan 11, 2016 at 12:52 PM, Hans Verkuil wrote:
>> Did you also test with v4l2-compliance? Before I accept the driver I want to
>> see the
>> output of 'v4l2-compliance' and 'v
On Mon, Jan 11, 2016 at 12:52 PM, Hans Verkuil wrote:
> Did you also test with v4l2-compliance? Before I accept the driver I want to
> see the
> output of 'v4l2-compliance' and 'v4l2-compliance -s'. Basically there
> shouldn't be
> any failures.
>
> I did a quick scan over the source and I saw n
Hi Andrey,
On 01/03/2016 02:41 AM, Andrey Utkin wrote:
> (Disclaimer up to scissors mark)
>
> Please be so kind to take a look at a new driver.
> We aim to follow high standards of kernel development and possibly to get
> this driver in mainline kernel.
> The device is multichannel video and aud
On Sun, Jan 3, 2016 at 5:47 AM, Joe Perches wrote:
> several of these have unnecessary parentheses
Thanks, fixed.
> Maybe use bool a bit more
Thanks, fixed.
> or maybe just use fls
Thanks, fls() fit greatly, rewritten the function with compatibility testing.
>> +static inline int bs_size_ue(
On Sun, 2016-01-03 at 03:41 +0200, Andrey Utkin wrote:
> (Disclaimer up to scissors mark)
>
> Please be so kind to take a look at a new driver.
trivial comments only:
> diff --git a/drivers/staging/media/tw5864/tw5864-bs.h
> b/drivers/staging/media/tw5864/tw5864-bs.h
[]
> +static inline int bs_p
On Sun, Jan 03, 2016 at 03:41:42AM +0200, Andrey Utkin wrote:
> +/*
> + * TW5864 driver - Exp-Golomb code functions
> + *
> + * Copyright (C) 2015 Bluecherry, LLC
> + * Copyright (C) 2015 Andrey Utkin
I doubt that you have contract with your employer which permits you to
claim copyright
13 matches
Mail list logo
