Den 03.03.2015 13:04, skrev Dan Carpenter:
On Tue, Mar 03, 2015 at 12:57:29PM +0100, Noralf Trønnes wrote:
+ ret = ctrl->rotate(ctrl, rotation);
+ if (!ret)
+ ctrl->rotation = rotation;
+
+ return ret;
Better to check "if (ret)" consistently (error handling vs s
On Tue, Mar 03, 2015 at 12:57:29PM +0100, Noralf Trønnes wrote:
> >>+ ret = ctrl->rotate(ctrl, rotation);
> >>+ if (!ret)
> >>+ ctrl->rotation = rotation;
> >>+
> >>+ return ret;
> >Better to check "if (ret)" consistently (error handling vs success
> >handling).
> Like this?
>
>
Den 02.03.2015 12:48, skrev Dan Carpenter:
[snip]
+ if (ctrl->power_supply) {
+ ret = regulator_enable(ctrl->power_supply);
+ if (ret) {
+ dev_err(ctrl->lcdreg->dev,
+ "failed to enable power supply: %d\n", r
On Mon, Mar 02, 2015 at 11:54:25AM +0100, Noralf Trønnes wrote:
> +int lcdctrl_enable(struct lcdctrl *ctrl, void *videomem)
> +{
> + struct lcdctrl_update update = {
> + .base = videomem,
> + .ys = 0,
> + .ye = lcdctrl_yres(ctrl) - 1,
> + };
> + int r
Add abstraction for MIPI DCS/DBI like LCD controllers.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig | 1 +
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft/lcdctrl/Kconfig | 3 +
drivers/staging/fbtft/lcdctrl/Makefile | 1 +
drivers/sta
