[RFC] staging: dgap: sparse warning question

2014-04-25 Thread Mark Hounschell
I get the sparse warning: drivers/staging/dgap/dgap.c:367:25: warning: too long initializer-string for array of char It's referring to INIT_C_CC in the following code segment. static struct ktermios DgapDefaultTermios = { .c_iflag = (DEFAULT_IFLAGS), /* iflags */ .c_of

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-26 Thread Dan Carpenter
On Mon, Mar 17, 2014 at 09:23:54AM -0400, Mark Hounschell wrote: > >. > > > > Hi Dan, what is going on with this patch? Are you going to submit > it? I want to get rid of the remaining LOCKing macros but think it > may mess you up with this? > Sorry, I went on vacation and I just returned. Than

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-17 Thread Mark Hounschell
On 03/07/2014 05:46 PM, Dan Carpenter wrote: I still prefer my patch. Unless I'm missing something? Could you review it and I will submit it as a patch tomorrow. regards, dan carpenter diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index d00283a226a2..783cd75a2d96 1006

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-10 Thread Mark Hounschell
On 03/08/2014 04:59 AM, Mark Hounschell wrote: On 03/07/2014 05:46 PM, Dan Carpenter wrote: I still prefer my patch. Unless I'm missing something? Could you review it and I will submit it as a patch tomorrow. I've reviewed it and see no obvious problems. If you like it better, I'm OK with

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-08 Thread Mark Hounschell
On 03/07/2014 05:46 PM, Dan Carpenter wrote: I still prefer my patch. Unless I'm missing something? Could you review it and I will submit it as a patch tomorrow. regards, dan carpenter diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index d00283a226a2..783cd75a2d96 1006

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-07 Thread Dan Carpenter
I still prefer my patch. Unless I'm missing something? Could you review it and I will submit it as a patch tomorrow. regards, dan carpenter diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index d00283a226a2..783cd75a2d96 100644 --- a/drivers/staging/dgap/dgap.c +++ b/driv

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-07 Thread Greg KH
On Fri, Mar 07, 2014 at 04:57:50PM -0500, Mark Hounschell wrote: > This is just for comments. The indentation was alread so far > over 80 chars I (as recommended earlier) make a couple of > new functions. Somehow I don't think this is proper and there > is probably a better way to do this. This is

[PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-07 Thread Mark Hounschell
This is just for comments. The indentation was alread so far over 80 chars I (as recommended earlier) make a couple of new functions. Somehow I don't think this is proper and there is probably a better way to do this. This is untested. Signed-off-by: Mark Hounschell --- drivers/staging/dgap/dgap

Re: [RFC]: staging: dgap

2014-02-25 Thread Dan Carpenter
On Tue, Feb 25, 2014 at 09:44:40AM -0500, Mark Hounschell wrote: > I have a couple basic questions concerning the Digi International > staging/dgap driver about how I might be able to help clean it up > more. > > 1. This driver has/had a built-in tracing system that during driver > and board devel

[RFC]: staging: dgap

2014-02-25 Thread Mark Hounschell
I have a couple basic questions concerning the Digi International staging/dgap driver about how I might be able to help clean it up more. 1. This driver has/had a built-in tracing system that during driver and board development that I'm sure was useful to Digi International at the time. Since