Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Jonathan Cameron
On February 24, 2014 2:26:58 PM GMT+00:00, Alexandre Belloni wrote: >Hi Juergen, > >On 24/02/2014 at 14:16:24 +0100, Juergen Beisert wrote : >> Hi Alexandre, >> >> > While I don't have much experience with the TS part of the code but >I >> > can investigate if you don't have any idea. >> >> c

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Dan Carpenter
On Mon, Feb 24, 2014 at 03:38:26PM +0100, Juergen Beisert wrote: > Hi Dan, > > On Monday 24 February 2014 14:33:16 Dan Carpenter wrote: > > On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote: > > > > While I don't have much experience with the TS part of the code but I > > > > can inv

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Juergen Beisert
Hi Dan, On Monday 24 February 2014 14:33:16 Dan Carpenter wrote: > On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote: > > > While I don't have much experience with the TS part of the code but I > > > can investigate if you don't have any idea. > > > > can you please test the followin

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Alexandre Belloni
Hi Juergen, On 24/02/2014 at 14:16:24 +0100, Juergen Beisert wrote : > Hi Alexandre, > > > While I don't have much experience with the TS part of the code but I > > can investigate if you don't have any idea. > > can you please test the following patch? > After releasing the touchscreen the inte

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Dan Carpenter
On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote: > Hi Alexandre, > > > While I don't have much experience with the TS part of the code but I > > can investigate if you don't have any idea. > > can you please test the following patch? > After releasing the touchscreen the internal

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Juergen Beisert
Hi Alexandre, > While I don't have much experience with the TS part of the code but I > can investigate if you don't have any idea. can you please test the following patch? After releasing the touchscreen the internal state machine was left in a wrong state. diff --git a/drivers/staging/iio/adc/

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-04 Thread Marek Vasut
On Friday, January 10, 2014 at 09:55:45 AM, Jürgen Beisert wrote: [...] > > While this is not necessarily an issue with ts_calibrate (it is possible > > to click longer so it collects more samples), I don't see that working > > with xinput_calibrator. > > > > While I don't have much experience w

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-01-10 Thread Jürgen Beisert
Hi Alexandre, On Thursday 09 January 2014 14:31:22 Alexandre Belloni wrote: > Sorry to chime in only now but it seems that this series is breaking the > touchscreen calibration on 3.13 (and -rc7 is out so it might be too > late). > > At first, I though I became a terrible clicker ;) but I found so

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-01-09 Thread Alexandre Belloni
Hi, Sorry to chime in only now but it seems that this series is breaking the touchscreen calibration on 3.13 (and -rc7 is out so it might be too late). At first, I though I became a terrible clicker ;) but I found some evidences: xinput_calibrator is complaining about misclicks, debug output: DE

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2013-10-01 Thread Marek Vasut
Dear Jonathan Cameron, > I'm looking for some Tested-by: or Acks on this before applying the series. > I got the impression from the comments on the previous version that the > series has now been reasonably thoroughly tested on both i.MX28 and i.MX23 > boards. This is not yet reflected in the sig

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2013-10-01 Thread Jonathan Cameron
I'm looking for some Tested-by: or Acks on this before applying the series. I got the impression from the comments on the previous version that the series has now been reasonably thoroughly tested on both i.MX28 and i.MX23 boards. This is not yet reflected in the sign off trail and in fact a coupl

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-23 Thread Marek Vasut
Dear Juergen Beisert, > The following series replaces the current busy loop touchscreen > implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven > implementation. > > Since i.MX23 and i.MX28 silicon differs, the existing implementation can > be used for the i.MX28 SoC only. > > The fi

[PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-23 Thread Juergen Beisert
The following series replaces the current busy loop touchscreen implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation. Since i.MX23 and i.MX28 silicon differs, the existing implementation can be used for the i.MX28 SoC only. The first patch adds proper clock handling. V