Re: [PATCHv3 02/16] staging: usbip: Add kernel support for client ACLs

2013-09-30 Thread Dan Carpenter
The main thing is that there is an IS_ERR vs NULL check. The rest is just style nits. On Sat, Sep 28, 2013 at 07:42:39PM +0200, Dominik Paulus wrote: > +static ssize_t store_acl(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t count) > +{ > +

[PATCHv3 02/16] staging: usbip: Add kernel support for client ACLs

2013-09-28 Thread Dominik Paulus
This patch adds the possibility to stored ACLs for allowed clients for each stub device in sysfs. It adds a new sysfs entry called "usbip_acl" for each stub device, containing a list of CIDR masks of allowed clients. This file will be used by usbip and usbipd to store the ACL. Signed-off-by: Kurt