RE: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

2017-12-08 Thread KY Srinivasan
vkuzn...@redhat.com; mga...@redhat.com; cav...@redhat.com > Subject: Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before > setting ip > > On Fri, Dec 08, Eduardo Otubo wrote: > > > tools/hv/hv_set_ifconfig.sh | 45 > +++-- &g

Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

2017-12-08 Thread Eduardo Otubo
On Fri, Dec 08, 2017 at 12:33:38PM +0100, Olaf Hering wrote: > On Fri, Dec 08, Eduardo Otubo wrote: > > > tools/hv/hv_set_ifconfig.sh | 45 > > +++-- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > +# let's wait for 3 minutes > > Was t

Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

2017-12-08 Thread Olaf Hering
On Fri, Dec 08, Eduardo Otubo wrote: > tools/hv/hv_set_ifconfig.sh | 45 > +++-- > 1 file changed, 43 insertions(+), 2 deletions(-) > +# let's wait for 3 minutes Was this codepath runtime tested? Last time this came up, the conclusion was that W

[PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

2017-12-08 Thread Eduardo Otubo
This patch fixes the behavior of the hv_set_ifconfig script when setting the interface ip. Sometimes the interface has already been configured by network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file exists error"; in order to avoid this error this patch makes sure double checks the