Re: [PATCHv2] staging: sm750fb: Add missing Kconfig dependency

2015-05-28 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, May 28, 2015 at 11:57:54AM +0300, Dan Carpenter wrote: > On Thu, May 28, 2015 at 08:54:12AM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > > > I resend v3 but it seems there is a duplicate signature.Please dicard it > > as well.I am sending v4 now. > > v3 is fine. The duplicate s

Re: [PATCHv2] staging: sm750fb: Add missing Kconfig dependency

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 08:54:12AM +, Gujulan Elango, Hari Prasath (H.) wrote: > > I resend v3 but it seems there is a duplicate signature.Please dicard it > as well.I am sending v4 now. v3 is fine. The duplicate sign-off is below the cut off line --- so it will be removed automatically. r

Re: [PATCHv2] staging: sm750fb: Add missing Kconfig dependency

2015-05-28 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, May 28, 2015 at 11:45:28AM +0300, Dan Carpenter wrote: > On Thu, May 28, 2015 at 08:40:41AM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > diff --git a/drivers/staging/sm750fb/Kconfig > > b/drivers/staging/sm750fb/Kconfig > > index c40d088..59d7c52 100644 > > --- a/drivers/staging/

Re: [PATCHv2] staging: sm750fb: Add missing Kconfig dependency

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 08:40:41AM +, Gujulan Elango, Hari Prasath (H.) wrote: > diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig > index c40d088..59d7c52 100644 > --- a/drivers/staging/sm750fb/Kconfig > +++ b/drivers/staging/sm750fb/Kconfig > @@ -1,6 +1,10 @@ >

[PATCHv2] staging: sm750fb: Add missing Kconfig dependency

2015-05-28 Thread Gujulan Elango, Hari Prasath (H.)
The sm750fb driver has few Framebuffer configuration dependencies that need to be selected in order to get compiled successfully. Signed-off-by: Gujulan Elango Hari Prasath --- v2:Addressed the review comments by Sudhip Mukherjee as I had missed out a few other dependencies for this drive