Re: [PATCH v6 08/24] erofs: add namei functions

2019-08-29 Thread Gao Xiang
On Thu, Aug 29, 2019 at 03:28:38AM -0700, Christoph Hellwig wrote: > On Fri, Aug 02, 2019 at 08:53:31PM +0800, Gao Xiang wrote: > > +struct erofs_qstr { > > + const unsigned char *name; > > + const unsigned char *end; > > +}; > > Maybe erofs_name? The q in qstr stands for quick, because of th

Re: [PATCH v6 08/24] erofs: add namei functions

2019-08-29 Thread Christoph Hellwig
On Fri, Aug 02, 2019 at 08:53:31PM +0800, Gao Xiang wrote: > +struct erofs_qstr { > + const unsigned char *name; > + const unsigned char *end; > +}; Maybe erofs_name? The q in qstr stands for quick, because of the existing hash and len, which this doesn't really provide. Also I don't rea

[PATCH v6 08/24] erofs: add namei functions

2019-08-02 Thread Gao Xiang
This commit adds functions that transfer names to inodes. Signed-off-by: Gao Xiang --- fs/erofs/namei.c | 247 +++ 1 file changed, 247 insertions(+) create mode 100644 fs/erofs/namei.c diff --git a/fs/erofs/namei.c b/fs/erofs/namei.c new file mode 10