Re: [PATCH v6 04/24] erofs: add raw address_space operations

2019-08-30 Thread Gao Xiang
Hi Christoph, On Fri, Aug 30, 2019 at 09:40:13AM -0700, Christoph Hellwig wrote: > On Thu, Aug 29, 2019 at 07:46:11PM +0800, Gao Xiang wrote: > > Hi Christoph, > > > > On Thu, Aug 29, 2019 at 03:17:21AM -0700, Christoph Hellwig wrote: > > > The actual address_space operations seem to largely dupl

Re: [PATCH v6 04/24] erofs: add raw address_space operations

2019-08-30 Thread Christoph Hellwig
On Thu, Aug 29, 2019 at 07:46:11PM +0800, Gao Xiang wrote: > Hi Christoph, > > On Thu, Aug 29, 2019 at 03:17:21AM -0700, Christoph Hellwig wrote: > > The actual address_space operations seem to largely duplicate > > the iomap versions. Please use those instead. Also I don't think > > any new fil

Re: [PATCH v6 04/24] erofs: add raw address_space operations

2019-08-29 Thread Gao Xiang
Hi Christoph, On Thu, Aug 29, 2019 at 03:17:21AM -0700, Christoph Hellwig wrote: > The actual address_space operations seem to largely duplicate > the iomap versions. Please use those instead. Also I don't think > any new file system should write up ->bmap these days. iomap doesn't support tail

Re: [PATCH v6 04/24] erofs: add raw address_space operations

2019-08-29 Thread Christoph Hellwig
The actual address_space operations seem to largely duplicate the iomap versions. Please use those instead. Also I don't think any new file system should write up ->bmap these days. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.li

[PATCH v6 04/24] erofs: add raw address_space operations

2019-08-02 Thread Gao Xiang
This commit adds functions for meta and raw data, and also provides address_space_operations for raw data access. Signed-off-by: Gao Xiang --- fs/erofs/data.c | 423 1 file changed, 423 insertions(+) create mode 100644 fs/erofs/data.c diff --git