Re: [PATCH v5 1/5] staging: unisys: remove redundant variable

2015-03-26 Thread Ben Romer
On 03/26/2015 09:47 AM, Ben Romer wrote: On 03/26/2015 08:01 AM, Greg Kroah-Hartman wrote: I need an ack from Benjamin and/or David before I can take these, as they are the maintainers of the driver, and have the ability to test these patches. I'll just wait to apply them until that happens. B

Re: [PATCH v5 1/5] staging: unisys: remove redundant variable

2015-03-26 Thread Ben Romer
On 03/26/2015 08:01 AM, Greg Kroah-Hartman wrote: I need an ack from Benjamin and/or David before I can take these, as they are the maintainers of the driver, and have the ability to test these patches. I'll just wait to apply them until that happens. Ben/David? I'll test them today. :) -- B

Re: [PATCH v5 1/5] staging: unisys: remove redundant variable

2015-03-26 Thread Greg Kroah-Hartman
On Tue, Mar 24, 2015 at 08:47:26PM +0530, Sudip Mukherjee wrote: > remove the variable "registered", which was used in the cleanup() to > detect if the driver has successfully initialized. the cleanup() > is called from module_exit, so its obvious that the module has > successfully initialized. if

Re: [PATCH v5 1/5] staging: unisys: remove redundant variable

2015-03-24 Thread Dan Carpenter
Great. :) Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v5 1/5] staging: unisys: remove redundant variable

2015-03-24 Thread Sudip Mukherjee
remove the variable "registered", which was used in the cleanup() to detect if the driver has successfully initialized. the cleanup() is called from module_exit, so its obvious that the module has successfully initialized. if the initialization had failed, then we will never be in the cleanup(). S