RE: [lustre-devel] [PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-09 Thread Simmons, James A.
>On Thu, Jun 04, 2015 at 10:34:20AM +0300, Dan Carpenter wrote: >> On Thu, Jun 04, 2015 at 11:05:54AM +0530, Sudip Mukherjee wrote: >> > On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: >> > > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c >> > looks like you have not jus

Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-08 Thread Joe Perches
On Mon, 2015-06-08 at 12:33 -0700, Greg Kroah-Hartman wrote: > Please generate patches in -M format, so I can see the rename properly, > as it is, this is too messy for me to review. Adding this to the .gitconfig works too [diff] renames = true That should probably be mentioned in Submit

Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-08 Thread Greg Kroah-Hartman
On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c > > Signed-off-by: James Simmons > --- > drivers/staging/lustre/lnet/lnet/Makefile |7 +- > drivers/staging/lustre/lnet/lnet/lib-socket.c | 624 > +

Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-04 Thread Sudip Mukherjee
On Thu, Jun 04, 2015 at 10:34:20AM +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2015 at 11:05:54AM +0530, Sudip Mukherjee wrote: > > On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: > > > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c > > looks like you have not just ren

Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-04 Thread Dan Carpenter
On Thu, Jun 04, 2015 at 11:05:54AM +0530, Sudip Mukherjee wrote: > On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: > > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c > looks like you have not just renamed the file, but there was also a change > in the #include which is n

Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c looks like you have not just renamed the file, but there was also a change in the #include which is not mentioned in the commit message. --- drivers/staging/lustre/lustre/li

[PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-03 Thread James Simmons
Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/Makefile |7 +- drivers/staging/lustre/lnet/lnet/lib-socket.c | 624 drivers/staging/lustre/lustre/libcfs/Makefile |1 -