Re: [PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-27 Thread Dan Carpenter
On Thu, Feb 27, 2014 at 11:54:23PM +, Russell King - ARM Linux wrote: > On Thu, Feb 27, 2014 at 02:52:34PM -0800, Greg KH wrote: > > > > How can dmfc ever be NULL? You control what values you pass to it, why > > check it again? > > Indeed. This is actually a case where the static checker wa

Re: [PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 02:52:34PM -0800, Greg KH wrote: > On Wed, Feb 26, 2014 at 08:53:39PM -0300, Fabio Estevam wrote: > > From: Fabio Estevam > > > > Fix the following static checker warning: > > > > drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() > > warn: variable d

Re: [PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-27 Thread Greg KH
On Wed, Feb 26, 2014 at 08:53:39PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Fix the following static checker warning: > > drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: > variable dereferenced before check 'dmfc' (see line 157) > > Reported-by: Dan Ca

[PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam --- Changes since v3: - None Changes sin