Re: [PATCH v4 1/4] staging: unisys: remove unneeded comparison

2015-03-24 Thread Sudip Mukherjee
On Tue, Mar 24, 2015 at 03:30:21PM +0300, Dan Carpenter wrote: > On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote: > > visorchipset_file_cleanup() is called from visorchipset_exit() which > > is the module_exit function and this function is executing means > > module_init succeeded,

Re: [PATCH v4 1/4] staging: unisys: remove unneeded comparison

2015-03-24 Thread Dan Carpenter
On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote: > visorchipset_file_cleanup() is called from visorchipset_exit() which > is the module_exit function and this function is executing means > module_init succeeded, so registered will always be true at this time. > and majordev has also

[PATCH v4 1/4] staging: unisys: remove unneeded comparison

2015-03-24 Thread Sudip Mukherjee
visorchipset_file_cleanup() is called from visorchipset_exit() which is the module_exit function and this function is executing means module_init succeeded, so registered will always be true at this time. and majordev has also been initialized in the init function. hence these comparisons will alwa