Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-16 Thread Jonathan Cameron
On Mon, 12 Nov 2018 07:57:24 + "Ardelean, Alexandru" wrote: > On Sun, 2018-11-11 at 14:30 +, Jonathan Cameron wrote: > > On Tue, 6 Nov 2018 09:24:44 + > > "Ardelean, Alexandru" wrote: > > > > > On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > > > > The ad7780 driver pr

Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-11 Thread Ardelean, Alexandru
On Sun, 2018-11-11 at 14:30 +, Jonathan Cameron wrote: > On Tue, 6 Nov 2018 09:24:44 + > "Ardelean, Alexandru" wrote: > > > On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > > > The ad7780 driver previously did not read the correct device output, > > > as > > > it read an outdate

Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-11 Thread Jonathan Cameron
On Tue, 6 Nov 2018 09:24:44 + "Ardelean, Alexandru" wrote: > On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > > The ad7780 driver previously did not read the correct device output, as > > it read an outdated value set at initialization. It now updates its > > voltage on read. > >

Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-06 Thread Ardelean, Alexandru
On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh > --- > Ch

[PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-05 Thread Renato Lui Geh
The ad7780 driver previously did not read the correct device output, as it read an outdated value set at initialization. It now updates its voltage on read. Signed-off-by: Renato Lui Geh --- Changes in v3: - removed initialization (int voltage_uv = 0) - returns error when voltage