Re: [PATCH v4] staging: lustre: llite: Fix variable length array warning

2017-05-09 Thread Guru Das Srinagesh
On Tue, May 09, 2017 at 11:31:36AM +0300, Dan Carpenter wrote: > Just ignore the warning. > Thank you for your comments on this patch. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-

Re: [PATCH v4] staging: lustre: llite: Fix variable length array warning

2017-05-09 Thread Dan Carpenter
This patch introduces tons of memory leaks so we can't apply it. Just ignore the warning. The size is small enough that it won't overflow the stack. The other reason to avoid these types of declarations is that in olden times (5 years ago at least) there was a GCC for an arch where if you declar

[PATCH v4] staging: lustre: llite: Fix variable length array warning

2017-05-08 Thread Guru Das Srinagesh
Fix sparse warning "warning: Variable length array is used." by using kmalloc_array to allocate the required amount of memory instead and kfree to deallocate memory after use. Signed-off-by: Guru Das Srinagesh --- v4: - Changed kmalloc_array flags from GFP_KERNEL to GFP_ATOMIC v3: - Fixe