Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-05 Thread Matt Sealey
On Mon, Nov 4, 2013 at 7:13 PM, Fabio Estevam wrote: > On Mon, Nov 4, 2013 at 9:20 PM, Matt Sealey wrote: > >> Fabio, Shawn, could you go so far as to bring this up with the i.MX >> guys responsible for documentation or find the original transmitter IP >> specs, or find the two pages missing from

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-05 Thread Matt Sealey
On Tue, Nov 5, 2013 at 5:35 PM, Fabio Estevam wrote: > On Tue, Nov 5, 2013 at 9:29 PM, Matt Sealey wrote: > >> I know about that one. BTW this isn't in the MX6SDL errata >> documentation, but it is in the MX6QD errata. If this actually affects >> the Solo etc. as Russell dictates, isn't the errat

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-05 Thread Fabio Estevam
On Tue, Nov 5, 2013 at 9:29 PM, Matt Sealey wrote: > I know about that one. BTW this isn't in the MX6SDL errata > documentation, but it is in the MX6QD errata. If this actually affects > the Solo etc. as Russell dictates, isn't the errata document missing > some info here? If you read the code y

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-04 Thread Fabio Estevam
On Mon, Nov 4, 2013 at 9:20 PM, Matt Sealey wrote: > Fabio, Shawn, could you go so far as to bring this up with the i.MX > guys responsible for documentation or find the original transmitter IP > specs, or find the two pages missing from the manual? This is a really The multiple writes comes fro

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-04 Thread Matt Sealey
On Thu, Oct 31, 2013 at 4:48 PM, Matt Sealey wrote: > On Thu, Oct 31, 2013 at 4:08 PM, Fabio Estevam wrote: >> On Thu, Oct 31, 2013 at 7:00 PM, Russell King - ARM Linux >> wrote: >> Interesting. With the monitor I have tested I am not able to see this magenta line. >>> >>> Monitor or T

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Matt Sealey
On Thu, Oct 31, 2013 at 4:08 PM, Fabio Estevam wrote: > On Thu, Oct 31, 2013 at 7:00 PM, Russell King - ARM Linux > wrote: > >>> Interesting. With the monitor I have tested I am not able to see this >>> magenta line. >> >> Monitor or TV? Beware of overscans which will hide this effect. > > I use

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Fabio Estevam
On Thu, Oct 31, 2013 at 7:00 PM, Russell King - ARM Linux wrote: >> Interesting. With the monitor I have tested I am not able to see this >> magenta line. > > Monitor or TV? Beware of overscans which will hide this effect. I used a PC monitor on my tests. I sent v5 using 4 as the number of loo

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Russell King - ARM Linux
On Thu, Oct 31, 2013 at 06:45:41PM -0200, Fabio Estevam wrote: > Hi Troy, > > On Thu, Oct 31, 2013 at 6:38 PM, Troy Kisky > wrote: > > >> I get a magenta line down the left side of the screen unless I replace the > >> 5 with a 6. > >> ie. > >> > >> +for (count = 0; count < 6; count++) > >> +

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Fabio Estevam
Hi Troy, On Thu, Oct 31, 2013 at 6:38 PM, Troy Kisky wrote: >> I get a magenta line down the left side of the screen unless I replace the >> 5 with a 6. >> ie. >> >> +for (count = 0; count < 6; count++) >> +hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF); >> >> >> This is with a imx6q proc

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Troy Kisky
On 10/31/2013 1:23 PM, Troy Kisky wrote: +/* Workaround to clear the overflow condition */ +static void imx_hdmi_clear_overflow(struct imx_hdmi *hdmi) +{ +int count; +u8 val; + +/* TMDS software reset */ +hdmi_writeb(hdmi, (u8)~HDMI_MC_SWRSTZ_TMDSSWRST_REQ, HDMI_MC_SWRSTZ); + +

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Troy Kisky
+/* Workaround to clear the overflow condition */ +static void imx_hdmi_clear_overflow(struct imx_hdmi *hdmi) +{ + int count; + u8 val; + + /* TMDS software reset */ + hdmi_writeb(hdmi, (u8)~HDMI_MC_SWRSTZ_TMDSSWRST_REQ, HDMI_MC_SWRSTZ); + + val = hdmi_readb(hdmi, HD