Re: [PATCH v3 3/6] staging: unisys: remove ASSERT() macro

2015-03-04 Thread Dan Carpenter
On Tue, Mar 03, 2015 at 10:50:40AM -0500, Benjamin Romer wrote: > #define sizeofmember(TYPE, MEMBER) (sizeof(((TYPE *)0)->MEMBER)) > /** "Covered quotient" function */ > #define COVQ(v, d) (((v) + (d) - 1) / (d)) > diff --git a/drivers/staging/unisys/visorutil/periodic_work.c > b/drivers/stagi

[PATCH v3 3/6] staging: unisys: remove ASSERT() macro

2015-03-03 Thread Benjamin Romer
Remove the ASSERT macro from timskmod.h, and replace its single use with WARN_ON() instead. Signed-off-by: Benjamin Romer --- v2 - Fixed a mistake where some of the if statements had accidentally doubled tabs when the then clause was only one statement. v3 - Fixed the doubled tabs missed in v2,