Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Gao Xiang
On 2019/7/23 12:35, Steven Rostedt wrote: > On Mon, 22 Jul 2019 23:33:53 +0800 > Gao Xiang wrote: > >> Hi Steven, >> >> On 2019/7/22 10:40, Steven Rostedt wrote: > and I'm not sure Al could accept __fdget conversion (I just wanted to > give a example then...) > > There

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Steven Rostedt
On Mon, 22 Jul 2019 23:33:53 +0800 Gao Xiang wrote: > Hi Steven, > > On 2019/7/22 10:40, Steven Rostedt wrote: > >>> and I'm not sure Al could accept __fdget conversion (I just wanted to > >>> give a example then...) > >>> > >>> Therefore, I tend to keep silence and just promote EROFS... so

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Gao Xiang
Hi Steven, On 2019/7/22 10:40, Steven Rostedt wrote: >>> and I'm not sure Al could accept __fdget conversion (I just wanted to give >>> a example then...) >>> >>> Therefore, I tend to keep silence and just promote EROFS... some better >>> ideas?... >>> >> Writing example conversion patches

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Steven Rostedt
On Mon, 22 Jul 2019 09:16:22 +0300 Amir Goldstein wrote: > CC kernel/trace maintainers for RB_PAGE_HEAD/RB_PAGE_UPDATE > and kernel/locking maintainers for RT_MUTEX_HAS_WAITERS Interesting. > > > (Is there some use scenerios in overlayfs and fanotify?...) > > We had one in overlayfs once. I

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Gao Xiang
On 2019/7/22 14:16, Amir Goldstein wrote: > On Mon, Jul 22, 2019 at 8:02 AM Gao Xiang wrote: >> >> Hi Amir, >> >> On 2019/7/22 12:39, Amir Goldstein wrote: >>> On Mon, Jul 22, 2019 at 5:54 AM Gao Xiang wrote: Currently kernel has scattered tagged pointer usages hacked by hand in

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Amir Goldstein
On Mon, Jul 22, 2019 at 8:02 AM Gao Xiang wrote: > > Hi Amir, > > On 2019/7/22 12:39, Amir Goldstein wrote: > > On Mon, Jul 22, 2019 at 5:54 AM Gao Xiang wrote: > >> > >> Currently kernel has scattered tagged pointer usages > >> hacked by hand in plain code, without a unique and > >> portable fun

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Gao Xiang
Hi Amir, On 2019/7/22 12:39, Amir Goldstein wrote: > On Mon, Jul 22, 2019 at 5:54 AM Gao Xiang wrote: >> >> Currently kernel has scattered tagged pointer usages >> hacked by hand in plain code, without a unique and >> portable functionset to highlight the tagged pointer >> itself and wrap these h

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Amir Goldstein
On Mon, Jul 22, 2019 at 5:54 AM Gao Xiang wrote: > > Currently kernel has scattered tagged pointer usages > hacked by hand in plain code, without a unique and > portable functionset to highlight the tagged pointer > itself and wrap these hacked code in order to clean up > all over meaningless magi

[PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Gao Xiang
Currently kernel has scattered tagged pointer usages hacked by hand in plain code, without a unique and portable functionset to highlight the tagged pointer itself and wrap these hacked code in order to clean up all over meaningless magic masks. This patch introduces simple generic methods to fold