Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

2015-03-16 Thread Joe Perches
On Mon, 2015-03-16 at 22:57 +0100, Mateusz Kulikowski wrote: > On 13.03.2015 01:27, Joe Perches wrote: > > > > Another thing you might consider is to change these > > embedded function names in another patch to use > > "%s: ", __func__ > > > > RT_TRACE(COMP_ERR, >

Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

2015-03-16 Thread Mateusz Kulikowski
On 13.03.2015 01:27, Joe Perches wrote: > > Another thing you might consider is to change these > embedded function names in another patch to use > "%s: ", __func__ > > RT_TRACE(COMP_ERR, >"%s: "unknown hardware version\n

Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

2015-03-16 Thread Mateusz Kulikowski
On 16.03.2015 09:44, Dan Carpenter wrote: > On Fri, Mar 13, 2015 at 12:53:16AM +0100, Mateusz Kulikowski wrote: >> -RT_TRACE(COMP_RECV, "HwRateToMRate90(): Non supported" >> - "Rate [%x], bIsHT = %d!!!\n", rate, bIsHT); >> -

Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

2015-03-16 Thread Dan Carpenter
On Fri, Mar 13, 2015 at 12:53:16AM +0100, Mateusz Kulikowski wrote: > - 'WARNING: break quoted strings at a space character' > @@ -1361,9 +1365,10 @@ static u8 HwRateToMRate90(bool bIsHT, u8 rate) > break; > > default: > - RT_TRACE(COMP_REC

Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

2015-03-12 Thread Joe Perches
On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote: [] > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c > b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c > index 0e6bdd2..01d2201 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c > +++ b/drivers/stagin

[PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

2015-03-12 Thread Mateusz Kulikowski
Fix checkpatch.pl warnings: - 'WARNING: quoted string split across lines' - 'WARNING: break quoted strings at a space character' Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 51 +++--- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 28 +-- dr