Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-09-08 Thread Andrey Danin
Wolfram, thanks! On 08.09.2015 14:46, Wolfram Sang wrote: Sorry for the long delay. I tried to analyze the issue. Attached patch works on AC100 (Misha Komarovsky helped me with testing). Wolfram could you please try the patch with your environment? No change, sadly. I don't get slave interr

Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-09-08 Thread Wolfram Sang
> Sorry for the long delay. I tried to analyze the issue. Attached patch works > on AC100 (Misha Komarovsky helped me with testing). > > Wolfram could you please try the patch with your environment? No change, sadly. I don't get slave interrupts. > Init function is called multuple times. If I2C

Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-08-20 Thread Andrey Danin
On 24.07.2015 13:52, Wolfram Sang wrote: At the begin of my work on this patchset I even denied clock disable call if slave is registered (to minimize code that can affect transfer). I hacked something like this, but it seems it was not enough. If only slave mode is used, then this logic is

Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-07-24 Thread Wolfram Sang
> At the begin of my work on this patchset I even denied clock disable call if > slave is registered (to minimize code that can affect transfer). I hacked something like this, but it seems it was not enough. > If only slave mode is used, then this logic is not needed. This is not sufficent. We

Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-07-24 Thread Andrey Danin
On 24.07.2015 12:27, Wolfram Sang wrote: Still doesn't work for me and I think I understand why. Do you run your I2C controller in slave mode only? Yes. That might work, but using it in master/slave mode simultanously won't work yet as I see it: * After every transfer (as master), clocks get

Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-07-24 Thread Wolfram Sang
Hi Andrey, On Mon, Jul 20, 2015 at 11:35:43PM +0300, Andrey Danin wrote: > Initialization code is based on NVEC driver. > > There is a HW bug in AP20 that was also mentioned in kernel sources > for Toshiba AC100. > > Signed-off-by: Andrey Danin Still doesn't work for me and I think I understan

[PATCH v3 1/4] i2c: tegra: implement slave mode

2015-07-20 Thread Andrey Danin
Initialization code is based on NVEC driver. There is a HW bug in AP20 that was also mentioned in kernel sources for Toshiba AC100. Signed-off-by: Andrey Danin --- Changes for v3: - handle 10-bit clients properly Changes for v2: - remove hack from tegra_i2c_clock_disable - replace slave status