Hi Daniel,
I'm honored to have your attention，and thanks for your advice.
I will finish the next version and submit it as soon as possible.
> > +
> > + lcrtc->ldev = ldev;
> > + lcrtc->reg_offset = index * REG_OFFSET;
> > + lcrtc->cfg_reg = CFG_RESET;
> > + lcrtc->crtc_id = index;
gt; Subject: Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson
7A1000 bridge chip
>
> Hi Chenyang,
>
> I browsed the code on lore and noticed a few things and thought it
> better to bring it to your attention now.
>
> The general structure of the drivers seems good and
Hi Chenyang,
I browsed the code on lore and noticed a few things and thought it
better to bring it to your attention now.
The general structure of the drivers seems good and coding style is
fine. The feedback is mostly stuff we have decided to do different over
time, so likely because you based t
On Fri, Jul 23, 2021 at 07:22:46PM +0200, Sam Ravnborg wrote:
> On Fri, Jul 23, 2021 at 10:57:56AM +0200, Daniel Vetter wrote:
> > On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote:
> > > From: Chenyang Li
> > >
> > > This patch adds an initial DRM driver for the Loongson LS7A1000
> > >
On Fri, Jul 23, 2021 at 10:57:56AM +0200, Daniel Vetter wrote:
> On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote:
> > From: Chenyang Li
> >
> > This patch adds an initial DRM driver for the Loongson LS7A1000
> > bridge chip(LS7A). The LS7A bridge chip contains two display
> > controlle
On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote:
> From: Chenyang Li
>
> This patch adds an initial DRM driver for the Loongson LS7A1000
> bridge chip(LS7A). The LS7A bridge chip contains two display
> controllers, support dual display output. The maximum support for
> each channel dis
On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote:
> +static int loongson_drm_load(struct drm_device *dev)
> +{
> + struct loongson_device *ldev;
> + int ret;
> +
> + ldev = devm_kzalloc(dev->dev, sizeof(*ldev), GFP_KERNEL);
> + if (!ldev)
> + return -ENOMEM;
>
From: Chenyang Li
This patch adds an initial DRM driver for the Loongson LS7A1000
bridge chip(LS7A). The LS7A bridge chip contains two display
controllers, support dual display output. The maximum support for
each channel display is to 1920x1080@60Hz.
At present, DC device detection and DRM drive
